Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed all functionalities of aif360 #493

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

divyaamin9825
Copy link

The ExponentiatedGradientFunction code ran differently for different systems if using CPU on colab.
Windows systems could run the code with no issues after installing aif360 with reductions functionality only while M1 Mac systems needed all functionalities of aif360 to run the issues with no errors otherwise it would throw a NameError in the root ExponentiatedGradientFunction code where it couldn't find import fairlearn.reductions as red.(Screenshots taken from on an M1 Mac system)
Screenshot 2023-09-22 at 6 53 02 PM
Screenshot 2023-09-22 at 6 49 08 PM

Signed-off-by: Divya Amin <divyaamin9825@gmail.com>
Installed all functionalities of aif360
@sne3091
Copy link
Collaborator

sne3091 commented Sep 26, 2023

Contributes towards #378

@hoffmansc
Copy link
Collaborator

Hi, @divyaamin9825. Thanks for looking into this.

I'd like to get to the bottom of the issue in this case instead of just installing everything. I'm a little confused by the setup. Are both machines, Windows and Mac, running on Colab? If so, shouldn't the operating system not matter? Either way, if there's some difference between OSes, it would be good to know so we can fix the 'Reductions' requirements.

From the screenshots it looks like you ran the notebook multiple times. Can you try restarting the kernel and installing from scratch?

@divyaamin9825
Copy link
Author

divyaamin9825 commented Sep 27, 2023

Hi @hoffmansc. I just ran the code again today with just aif360[Reductions, LawSchoolGPA] on colab and it runs smoothly. However the day of the open source day, installing just those two functionalities was simply not working even in the first run for me on colab. So I had to install all the functionalities. My windows using teammates had their code running smoothly after installing just reductions on colab. I needed reductions and LawSchoolGPA locally and tried reflecting the same on colab, but I kept encountering the error in the screenshots even after restarting the kernel and running the code fresh.

@divyaamin9825
Copy link
Author

@hoffmansc Hi Samuel, any updates on this?

@hoffmansc
Copy link
Collaborator

So it works without needing to install [all], right? It should only require [Reductions] not [Reductions,LawSchoolGPA]. Can you update the PR to reflect this?

Can you also add a "Open in Colab" badge to the top like the other examples (e.g., https://github.com/Trusted-AI/AIF360/blob/master/examples/sklearn/demo_grid_search_reduction_classification_sklearn.ipynb)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants