Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GRAPHITE Attack #1751

Closed
wants to merge 76 commits into from
Closed

Conversation

ryan-feng
Copy link
Contributor

Description

Add GRAPHITE attack (https://arxiv.org/pdf/2002.07088.pdf, https://github.com/ryan-feng/GRAPHITE)

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • Tested with notebooks
  • Independently tested for correctness
  • Test cases added, did not know how to run outside of the PR

Test Configuration:

  • OS - Ubuntu
  • Python 3.8
  • ART version or commit number: f073851
  • Torch version 1.7

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@beat-buesser beat-buesser self-assigned this Jun 28, 2022
@beat-buesser beat-buesser added the enhancement New feature or request label Jun 28, 2022
@beat-buesser beat-buesser added this to the ART 1.12.0 milestone Jun 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2022

Codecov Report

Merging #1751 (1444b0b) into dev_1.12.0 (9fa6749) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 1444b0b differs from pull request most recent head b3259aa. Consider uploading reports for the commit b3259aa to get more accurate results

Impacted file tree graph

@@              Coverage Diff               @@
##           dev_1.12.0    #1751      +/-   ##
==============================================
- Coverage       85.57%   85.55%   -0.03%     
==============================================
  Files             271      271              
  Lines           23048    23048              
  Branches         4103     4103              
==============================================
- Hits            19723    19718       -5     
- Misses           2316     2319       +3     
- Partials         1009     1011       +2     
Impacted Files Coverage Δ
art/attacks/evasion/sign_opt.py 86.49% <ø> (ø)
art/estimators/certification/deep_z/pytorch.py 87.50% <ø> (ø)
...certification/derandomized_smoothing/tensorflow.py 85.00% <100.00%> (ø)
art/estimators/certification/abstain.py 90.90% <0.00%> (-9.10%) ⬇️
art/estimators/poison_mitigation/strip/strip.py 94.44% <0.00%> (-5.56%) ⬇️
art/attacks/evasion/boundary.py 92.77% <0.00%> (-1.21%) ⬇️

@lgtm-com
Copy link

lgtm-com bot commented Jun 28, 2022

This pull request introduces 36 alerts when merging c9d55e6 into 520bf0b - view on LGTM.com

new alerts:

  • 15 for Unused local variable
  • 9 for Unused import
  • 8 for Variable defined multiple times
  • 2 for 'import *' may pollute namespace
  • 1 for Modification of parameter with default
  • 1 for Unreachable code

@beat-buesser beat-buesser linked an issue Jun 28, 2022 that may be closed by this pull request
@beat-buesser
Copy link
Collaborator

Hi @ryan-feng Thank you very much for your pull request!

@beat-buesser beat-buesser added this to Issues open in ART 1.12.0 Jun 29, 2022
@ryan-feng ryan-feng changed the base branch from dev_1.11.0 to dev_1.12.0 July 1, 2022 14:36
@lgtm-com
Copy link

lgtm-com bot commented Jul 1, 2022

This pull request introduces 6 alerts when merging fc3485b into 9b99b6f - view on LGTM.com

new alerts:

  • 3 for Unused local variable
  • 1 for Unused import
  • 1 for Modification of parameter with default
  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Jul 1, 2022

This pull request introduces 8 alerts and fixes 8 when merging fc3485b into 8ccf19e - view on LGTM.com

new alerts:

  • 3 for Unused local variable
  • 2 for Module is imported more than once
  • 1 for Unused import
  • 1 for Modification of parameter with default
  • 1 for Unreachable code

fixed alerts:

  • 5 for Module is imported with 'import' and 'import from'
  • 2 for Missing call to `__init__` during object initialization
  • 1 for Variable defined multiple times

@beat-buesser beat-buesser changed the base branch from dev_1.12.0 to main July 5, 2022 18:39
@beat-buesser beat-buesser changed the base branch from main to dev_1.12.0 July 5, 2022 18:40
@lgtm-com
Copy link

lgtm-com bot commented Jul 5, 2022

This pull request introduces 6 alerts when merging fc3485b into 45ca8f8 - view on LGTM.com

new alerts:

  • 3 for Unused local variable
  • 1 for Unused import
  • 1 for Modification of parameter with default
  • 1 for Unreachable code

Signed-off-by: Ryan Feng <ryan_feng@yahoo.com>
@lgtm-com
Copy link

lgtm-com bot commented Jul 7, 2022

This pull request introduces 1 alert when merging 39a13dd into 45ca8f8 - view on LGTM.com

new alerts:

  • 1 for Unreachable code

Signed-off-by: Ryan Feng <ryan_feng@yahoo.com>
Signed-off-by: Ryan Feng <ryan_feng@yahoo.com>
Signed-off-by: Ryan Feng <ryan_feng@yahoo.com>
Signed-off-by: Ryan Feng <ryan_feng@yahoo.com>
Signed-off-by: Ryan Feng <ryan_feng@yahoo.com>
dependabot bot and others added 6 commits August 8, 2022 17:10
Bumps [docker/login-action](https://github.com/docker/login-action) from 1.10.0 to 2.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](docker/login-action@f054a8b...49ed152)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Ryan Feng <ryan_feng@yahoo.com>
…actions/docker/login-action-2

Bump docker/login-action from 1.10.0 to 2
…actions/docker/metadata-action-4.0.1

Bump docker/metadata-action from 3.3.0 to 4.0.1
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@lgtm-com
Copy link

lgtm-com bot commented Aug 8, 2022

This pull request introduces 5 alerts when merging 95ba208 into b85bc5d - view on LGTM.com

new alerts:

  • 5 for Module is imported more than once

Signed-off-by: Ryan Feng <ryan_feng@yahoo.com>
@lgtm-com
Copy link

lgtm-com bot commented Aug 9, 2022

This pull request introduces 5 alerts when merging e9851bc into b85bc5d - view on LGTM.com

new alerts:

  • 5 for Module is imported more than once

Beat Buesser and others added 7 commits August 9, 2022 11:31
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Ryan Feng <ryan_feng@yahoo.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@lgtm-com
Copy link

lgtm-com bot commented Aug 9, 2022

This pull request introduces 5 alerts when merging 20fb7a4 into b85bc5d - view on LGTM.com

new alerts:

  • 5 for Module is imported more than once

Signed-off-by: Ryan Feng <ryan_feng@yahoo.com>
@lgtm-com
Copy link

lgtm-com bot commented Aug 10, 2022

This pull request introduces 5 alerts when merging 6ae06f5 into b85bc5d - view on LGTM.com

new alerts:

  • 5 for Module is imported more than once

bluemurder and others added 4 commits August 17, 2022 00:05
Fix error `RuntimeError: tf.placeholder() is not compatible with eager execution.`
Signed-off-by: Alessio Leoncini <bluemurder@users.noreply.github.com>
…py-gte-1.18.5-and-lt-1.24

Update numpy requirement from <=1.22,>=1.18.5 to >=1.18.5,<1.24
@lgtm-com
Copy link

lgtm-com bot commented Aug 24, 2022

This pull request introduces 5 alerts when merging b3259aa into 9de8f4f - view on LGTM.com

new alerts:

  • 5 for Module is imported more than once

@ryan-feng ryan-feng mentioned this pull request Aug 24, 2022
15 tasks
@beat-buesser
Copy link
Collaborator

Closing this PR because work continues in #1828

@beat-buesser beat-buesser moved this from Issues open to Issues in progress in ART 1.12.0 Sep 24, 2022
@beat-buesser beat-buesser moved this from Issues in progress to Issues closed in ART 1.12.0 Sep 24, 2022
@beat-buesser beat-buesser moved this from Issues closed to Pull request done in ART 1.12.0 Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
ART 1.12.0
Pull request done
Development

Successfully merging this pull request may close these issues.

GRAPHITE Implementation
8 participants