New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for deepspeech v3 in ASR attack and Deepspeech estimator #1107
Conversation
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Codecov Report
@@ Coverage Diff @@
## dev_1.7.0 #1107 +/- ##
==============================================
- Coverage 64.45% 41.18% -23.28%
==============================================
Files 221 221
Lines 19295 19328 +33
Branches 3533 3549 +16
==============================================
- Hits 12437 7960 -4477
- Misses 5438 10407 +4969
+ Partials 1420 961 -459
|
…ustness-toolbox into deepspeech_v3
scikit-image | ||
|
||
# Install necessary libraries for deepspeech v3 | ||
RUN pip install torch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we define a version for torch
since we define an older version for torchaudio
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is already defined with the base image.
|
||
# Install necessary libraries for deepspeech v3 | ||
RUN pip install torch | ||
RUN pip install tensorflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is tensorflow
required in this test image for PyTorch models?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for some "import" in the conftest.py file which is not created by this PR, without tensorflow, error occurs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @minhitbk Thank you very much for adding support for DeepSpeech v3!
I have proposed a few small changes to account for recent CI updates and a few questions, what do you think?
Co-authored-by: Beat Buesser <49047826+beat-buesser@users.noreply.github.com>
Description
This PR implements support for Deepspeech V3 in ASR attack and the estimator. In addition, the Deepspeech V3 testing environment is also created.
Fixes #911
Fixes #1033
Type of change
Please check all relevant options.
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
Test Configuration:
Checklist