Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove art.classifiers and art.wrappers #1256

Merged
merged 8 commits into from
Sep 8, 2021

Conversation

beat-buesser
Copy link
Collaborator

@beat-buesser beat-buesser commented Aug 3, 2021

Signed-off-by: Beat Buesser beat.buesser@ie.ibm.com

Description

This pull request removes deprecated art.classifiers and art.wrappers.

  • tools of art.wrappers.expectation have been replaced with tools in art.preprocessing.expectation_over_transformation
  • tools of art.wrappers.query_efficient_bb have been replaced with tools in art.estimators
  • art.classifiers has been replaced with art.estimators.classification

Fixes #1195 #65

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@beat-buesser beat-buesser self-assigned this Aug 3, 2021
@beat-buesser beat-buesser added the improvement Improve implementation label Aug 3, 2021
@beat-buesser beat-buesser added this to Pull request open in ART 1.8.0 via automation Aug 3, 2021
@beat-buesser beat-buesser added this to the ART 1.8.0 milestone Aug 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2021

Codecov Report

Merging #1256 (878cce7) into dev_1.8.0 (56a9fad) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           dev_1.8.0    #1256      +/-   ##
=============================================
- Coverage      81.32%   81.31%   -0.01%     
=============================================
  Files            229      226       -3     
  Lines          19350    19284      -66     
  Branches        3505     3499       -6     
=============================================
- Hits           15736    15681      -55     
+ Misses          2313     2305       -8     
+ Partials        1301     1298       -3     
Impacted Files Coverage Δ
art/estimators/classification/blackbox.py 95.09% <ø> (ø)
art/estimators/classification/catboost.py 87.50% <ø> (ø)
...t/estimators/classification/detector_classifier.py 95.78% <ø> (ø)
art/estimators/classification/lightgbm.py 81.69% <ø> (ø)
art/estimators/classification/mxnet.py 74.83% <ø> (ø)
art/estimators/classification/scikitlearn.py 86.64% <ø> (ø)
art/estimators/classification/xgboost.py 85.85% <ø> (ø)
art/utils.py 74.08% <ø> (ø)
art/estimators/classification/__init__.py 100.00% <100.00%> (ø)
...rt/estimators/classification/query_efficient_bb.py 100.00% <100.00%> (ø)
... and 1 more

Beat Buesser added 5 commits August 3, 2021 15:31
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Copy link
Collaborator

@GiulioZizzo GiulioZizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Beat, many thanks for the review. The proposed changes look good to me!

@beat-buesser
Copy link
Collaborator Author

Hi @GiulioZizzo Thank you very much!

@beat-buesser beat-buesser merged commit 58839f7 into dev_1.8.0 Sep 8, 2021
ART 1.8.0 automation moved this from Pull request open to Pull request done Sep 8, 2021
@beat-buesser beat-buesser deleted the development_issue_1195 branch September 8, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve implementation
Projects
No open projects
ART 1.8.0
  
Pull request done
3 participants