-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove art.classifiers and art.wrappers #1256
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
This was
linked to
issues
Aug 3, 2021
Codecov Report
@@ Coverage Diff @@
## dev_1.8.0 #1256 +/- ##
=============================================
- Coverage 81.32% 81.31% -0.01%
=============================================
Files 229 226 -3
Lines 19350 19284 -66
Branches 3505 3499 -6
=============================================
- Hits 15736 15681 -55
+ Misses 2313 2305 -8
+ Partials 1301 1298 -3
|
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
GiulioZizzo
reviewed
Sep 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Beat, many thanks for the review. The proposed changes look good to me!
Hi @GiulioZizzo Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Beat Buesser beat.buesser@ie.ibm.com
Description
This pull request removes deprecated
art.classifiers
andart.wrappers
.art.wrappers.expectation
have been replaced with tools inart.preprocessing.expectation_over_transformation
art.wrappers.query_efficient_bb
have been replaced with tools inart.estimators
art.classifiers
has been replaced withart.estimators.classification
Fixes #1195 #65
Type of change
Please check all relevant options.