Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check_and_transform_label_format for index labels #1443

Merged
merged 5 commits into from
Dec 16, 2021

Conversation

beat-buesser
Copy link
Collaborator

Description

Fix missing transformation of binary index to one-hot encoded labels in art.utils.check_and_transform_label_format.

Fixes #1334

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@beat-buesser beat-buesser self-assigned this Dec 14, 2021
@beat-buesser beat-buesser added bug Something isn't working improvement Improve implementation labels Dec 14, 2021
@beat-buesser beat-buesser added this to Pull request open in ART 1.9.0 via automation Dec 14, 2021
@beat-buesser beat-buesser added this to the ART 1.9.0 milestone Dec 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2021

Codecov Report

Merging #1443 (e594795) into dev_1.9.0 (df2e613) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           dev_1.9.0    #1443   +/-   ##
==========================================
  Coverage      90.30%   90.31%           
==========================================
  Files            240      240           
  Lines          19679    19682    +3     
  Branches        3490     3490           
==========================================
+ Hits           17771    17775    +4     
+ Misses          1112     1110    -2     
- Partials         796      797    +1     
Impacted Files Coverage Δ
art/attacks/evasion/pixel_threshold.py 91.21% <50.00%> (+0.04%) ⬆️
art/utils.py 91.15% <90.00%> (+0.22%) ⬆️
art/estimators/classification/keras.py 88.41% <100.00%> (+0.70%) ⬆️
art/defences/detector/poison/activation_defence.py 84.84% <0.00%> (-1.35%) ⬇️
art/estimators/classification/pytorch.py 89.19% <0.00%> (+0.55%) ⬆️

Beat Buesser and others added 4 commits December 15, 2021 16:33
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@beat-buesser beat-buesser merged commit a7c1f7b into dev_1.9.0 Dec 16, 2021
ART 1.9.0 automation moved this from Pull request open to Pull request done Dec 16, 2021
@beat-buesser beat-buesser deleted the development_issue_1334 branch December 16, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement Improve implementation
Projects
No open projects
ART 1.9.0
  
Pull request done
Development

Successfully merging this pull request may close these issues.

check_and_transform_label_format with return_one_hot=True does not one hot encode when nb_classes=2
2 participants