Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import of matplotlib in laser attack utils #1467

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

beat-buesser
Copy link
Collaborator

Signed-off-by: Beat Buesser beat.buesser@ie.ibm.com

Description

This pull request fixes the import of matplotlib in laser attack utils.

Fixes #1456

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@beat-buesser beat-buesser self-assigned this Jan 4, 2022
@beat-buesser beat-buesser added bug Something isn't working improvement Improve implementation labels Jan 4, 2022
@beat-buesser beat-buesser added this to Pull request open in ART 1.9.1 via automation Jan 4, 2022
@beat-buesser beat-buesser added this to the ART 1.9.1 milestone Jan 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2022

Codecov Report

Merging #1467 (208591d) into dev_1.9.1 (40afe64) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           dev_1.9.1    #1467   +/-   ##
==========================================
  Coverage      89.88%   89.89%           
==========================================
  Files            244      244           
  Lines          19761    19761           
  Branches        3495     3495           
==========================================
+ Hits           17763    17764    +1     
  Misses          1200     1200           
+ Partials         798      797    -1     
Impacted Files Coverage Δ
art/attacks/evasion/laser_attack/utils.py 82.40% <0.00%> (-0.80%) ⬇️
art/attacks/evasion/boundary.py 93.93% <0.00%> (+1.21%) ⬆️

Copy link
Collaborator

@keykholt keykholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @beat-buesser for submitting a fix quickly. Fix seems reasonable

@beat-buesser beat-buesser merged commit 3d2c252 into dev_1.9.1 Jan 5, 2022
ART 1.9.1 automation moved this from Pull request open to Pull request done Jan 5, 2022
@beat-buesser beat-buesser deleted the development_issue_1456 branch January 5, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement Improve implementation
Projects
No open projects
ART 1.9.1
  
Pull request done
Development

Successfully merging this pull request may close these issues.

ImportError when importing art 1.9.0 due to matplotlib in laser_attack.utils
3 participants