Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace x with x_preprocessed in PyTorchClassifier.get_activations #1471

Merged
merged 2 commits into from
Jan 6, 2022

Conversation

beat-buesser
Copy link
Collaborator

Signed-off-by: Beat Buesser beat.buesser@ie.ibm.com

Description

This pull request replaces x with x_preprocessed in PyTorchClassifier.get_activations for framework=True.

Fixes #1468

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@beat-buesser beat-buesser self-assigned this Jan 5, 2022
@beat-buesser beat-buesser added bug Something isn't working improvement Improve implementation labels Jan 5, 2022
@beat-buesser beat-buesser added this to Pull request open in ART 1.9.1 via automation Jan 5, 2022
@beat-buesser beat-buesser added this to the ART 1.9.1 milestone Jan 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022

Codecov Report

Merging #1471 (437f5ad) into dev_1.9.1 (40afe64) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           dev_1.9.1    #1471      +/-   ##
=============================================
+ Coverage      89.88%   89.93%   +0.04%     
=============================================
  Files            244      244              
  Lines          19761    19901     +140     
  Branches        3495     3554      +59     
=============================================
+ Hits           17763    17898     +135     
  Misses          1200     1200              
- Partials         798      803       +5     
Impacted Files Coverage Δ
art/estimators/classification/pytorch.py 89.28% <100.00%> (+0.08%) ⬆️
art/attacks/evasion/laser_attack/utils.py 84.39% <0.00%> (+1.19%) ⬆️
art/estimators/classification/keras.py 91.30% <0.00%> (+2.89%) ⬆️

Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@beat-buesser beat-buesser merged commit 676b996 into dev_1.9.1 Jan 6, 2022
ART 1.9.1 automation moved this from Pull request open to Pull request done Jan 6, 2022
@beat-buesser beat-buesser deleted the development_issue_1468 branch January 6, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement Improve implementation
Projects
No open projects
ART 1.9.1
  
Pull request done
Development

Successfully merging this pull request may close these issues.

get_activations for pytorch_estimator returns incorrect values when framework=True?
2 participants