Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename python_object_detector.py to pytorch_object_detector.py #1687

Merged
merged 1 commit into from
May 18, 2022

Conversation

beat-buesser
Copy link
Collaborator

Signed-off-by: Beat Buesser beat.buesser@ie.ibm.com

Description

This pull request renames file python_object_detector.py to pytorch_object_detector.py following ART's naming convention.

Fixes #1686

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@beat-buesser beat-buesser self-assigned this May 13, 2022
@beat-buesser beat-buesser added the improvement Improve implementation label May 13, 2022
@beat-buesser beat-buesser added this to Pull request open in ART 1.10.2 via automation May 13, 2022
@beat-buesser beat-buesser added this to the ART 1.10.2 milestone May 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #1687 (94428b0) into dev_1.10.2 (67fa652) will decrease coverage by 0.68%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           dev_1.10.2    #1687      +/-   ##
==============================================
- Coverage       88.07%   87.38%   -0.69%     
==============================================
  Files             259      259              
  Lines           21354    21354              
  Branches         3791     3791              
==============================================
- Hits            18807    18661     -146     
- Misses           1601     1750     +149     
+ Partials          946      943       -3     
Impacted Files Coverage Δ
...mators/object_detection/pytorch_object_detector.py 79.21% <ø> (ø)
art/utils.py 74.95% <ø> (-0.51%) ⬇️
art/estimators/object_detection/__init__.py 100.00% <100.00%> (ø)
...estimators/object_detection/pytorch_faster_rcnn.py 100.00% <100.00%> (ø)
...estimators/speech_recognition/tensorflow_lingvo.py 18.27% <0.00%> (-73.10%) ⬇️
art/estimators/tensorflow.py 77.77% <0.00%> (-2.03%) ⬇️
art/estimators/poison_mitigation/strip/strip.py 100.00% <0.00%> (+5.55%) ⬆️
art/estimators/certification/abstain.py 100.00% <0.00%> (+9.09%) ⬆️

Copy link
Collaborator

@GiulioZizzo GiulioZizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Beat, the name changes all seem fine to me as they are. I don't see anything further that needs to be done for the PR!

@beat-buesser
Copy link
Collaborator Author

@GiulioZizzo Thank you very much!

@beat-buesser beat-buesser merged commit cdb081a into dev_1.10.2 May 18, 2022
ART 1.10.2 automation moved this from Pull request open to Pull request done May 18, 2022
@beat-buesser beat-buesser deleted the development_issue_1686 branch May 18, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve implementation
Projects
No open projects
ART 1.10.2
  
Pull request done
Development

Successfully merging this pull request may close these issues.

Rename file art.estimators.object_detection.python_object_detector.py to pytorch_object_detector.py
3 participants