Send nb_classes to check_and_transform_label_format in inference attacks #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abigailt <abigailt@il.ibm.com>
Signed-off-by: abigailt <abigailt@il.ibm.com>
…ship attacks as well) Signed-off-by: abigailt <abigailt@il.ibm.com>
Signed-off-by: abigailt <abigailt@il.ibm.com>
Signed-off-by: abigailt <abigailt@il.ibm.com>
Signed-off-by: abigailt <abigailt@il.ibm.com>
…ship attacks as well) Signed-off-by: abigailt <abigailt@il.ibm.com>
Signed-off-by: abigailt <abigailt@il.ibm.com>
… dev_1.11.0_attribute_fixes # Conflicts: # art/attacks/inference/attribute_inference/black_box.py # art/attacks/inference/attribute_inference/true_label_baseline.py
Signed-off-by: abigailt <abigailt@il.ibm.com>
Codecov Report
@@ Coverage Diff @@
## dev_1.11.0 #1713 +/- ##
==============================================
- Coverage 88.04% 84.27% -3.77%
==============================================
Files 260 260
Lines 21442 21448 +6
Branches 3809 3809
==============================================
- Hits 18879 18076 -803
- Misses 1612 2450 +838
+ Partials 951 922 -29
|
Signed-off-by: abigailt <abigailt@il.ibm.com>
Comment on lines
129
to
130
| if self._values is not None: | ||
| self._nb_classes = len(self._values) |
There was a problem hiding this comment.
Do we need these two lines? Or can we document the definition with len(self._values) in a comment in line 128?
Suggested change
| if self._values is not None: | |
| self._nb_classes = len(self._values) |
Comment on lines
139
to
140
| if self._values is not None: | ||
| self._nb_classes = len(self._values) |
There was a problem hiding this comment.
Do we need these two lines? Or can we document the definition with len(self._values) in a comment in line 138?
Comment on lines
115
to
116
| if self._values is not None: | ||
| self._nb_classes = len(self._values) |
There was a problem hiding this comment.
Do we need these two lines? Or can we document the definition with len(self._values) in a comment in line 114?
beat-buesser
requested changes
May 25, 2022
There was a problem hiding this comment.
Hi @abigailgold Thank you very much for your pull request. I think the updates look good. I have a question about 2 lines in each class if they are required. What do you think?
Signed-off-by: abigailt <abigailt@il.ibm.com>
beat-buesser
added
bug
beat-buesser
approved these changes
Jun 20, 2022
There was a problem hiding this comment.
Hi @abigailgold Thank you very much. The code looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Send nb_classes to check_and_transform_label_format in inference attacks.
Fixes #1712
Type of change
Please check all relevant options.
Testing
New test that sends labels as column vector.
Test Configuration:
Checklist