Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check from BoundaryAttack to enable binary classification #1897

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

beat-buesser
Copy link
Collaborator

Signed-off-by: Beat Buesser beat.buesser@ie.ibm.com

Description

This pull request removes a check from BoundaryAttack to enable binary classification.

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@beat-buesser beat-buesser self-assigned this Nov 2, 2022
@beat-buesser beat-buesser added the improvement Improve implementation label Nov 2, 2022
@beat-buesser beat-buesser added this to Pull request open in ART 1.12.2 via automation Nov 2, 2022
@beat-buesser beat-buesser added this to the ART 1.12.2 milestone Nov 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Merging #1897 (c1377de) into dev_1.12.2 (ef53a70) will increase coverage by 2.79%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           dev_1.12.2    #1897      +/-   ##
==============================================
+ Coverage       83.05%   85.85%   +2.79%     
==============================================
  Files             248      248              
  Lines           23320    23319       -1     
  Branches         4214     4214              
==============================================
+ Hits            19369    20020     +651     
+ Misses           2914     2234     -680     
- Partials         1037     1065      +28     
Impacted Files Coverage Δ
art/attacks/evasion/boundary.py 93.93% <ø> (-0.04%) ⬇️
art/estimators/poison_mitigation/strip/strip.py 100.00% <0.00%> (+5.55%) ⬆️
...timators/speech_recognition/pytorch_deep_speech.py 94.11% <0.00%> (+9.01%) ⬆️
art/estimators/certification/abstain.py 100.00% <0.00%> (+9.09%) ⬆️
art/estimators/classification/scikitlearn.py 90.86% <0.00%> (+10.69%) ⬆️
art/estimators/regression/scikitlearn.py 92.63% <0.00%> (+25.26%) ⬆️
...adversarial_texture/adversarial_texture_pytorch.py 90.00% <0.00%> (+28.00%) ⬆️
art/estimators/classification/xgboost.py 87.62% <0.00%> (+29.89%) ⬆️
art/estimators/classification/lightgbm.py 95.00% <0.00%> (+46.66%) ⬆️
art/metrics/gradient_check.py 100.00% <0.00%> (+54.54%) ⬆️
... and 3 more

Copy link
Collaborator

@kieranfraser kieranfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@beat-buesser beat-buesser merged commit 4e226f2 into dev_1.12.2 Nov 9, 2022
ART 1.12.2 automation moved this from Pull request open to Pull request done Nov 9, 2022
@beat-buesser beat-buesser deleted the development_boundary_attack branch November 9, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve implementation
Projects
No open projects
ART 1.12.2
  
Pull request done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants