BadDet Regional Misclassification Attack Bug Fix

[f4str]

Description

Upon further investigation of the BadDet attacks in the supplemental materials, the Regional Misclassification Attack (RMA) should be able to poison all bounding boxes regardless of the class type.

To address this bug/missing feature, the source_class parameter for BadDetRegionalMisclassificationAttack has been changed to additionally accept None (or just be left blank). Therefore, if no source is provided then all classes will be poisoned. Otherwise, if the source is provided then only that class will be poisoned. This will implement the missing feature and keep additional functionality for single class poisoning.

The BadDet demo in notebook/poisoning_attack_bad_det.ipynb has been updated to show this new feature.

Fixes #2111

Type of change

• Improvement (non-breaking)
• Bug fix (non-breaking)
• New feature (non-breaking)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

• Updated the BadDet RMA test case with this new feature.

Test Configuration:

• OS
• Python version
• ART version or commit number
• TensorFlow / Keras / PyTorch / MXNet version

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[codecov-commenter]

Codecov Report

Merging #2110 (3607185) into dev_1.14.1 (30e513c) will increase coverage by 9.64%.
The diff coverage is 33.33%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@              Coverage Diff               @@
##           dev_1.14.1    #2110      +/-   ##
==============================================
+ Coverage       75.97%   85.62%   +9.64%     
==============================================
  Files             297      297              
  Lines           26516    26516              
  Branches         4867     4867              
==============================================
+ Hits            20145    22703    +2558     
+ Misses           5325     2574    -2751     
- Partials         1046     1239     +193     

Impacted Files	Coverage Δ
art/attacks/poisoning/bad_det/bad_det_rma.py	96.42% <33.33%> (ø)

... and 41 files with indirect coverage changes

[beat-buesser]

Hi @f4str Thank you very much! The changes look good to me.