Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Fix in spatial_smoothing.py #2211

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

Foxglove144
Copy link
Contributor

@Foxglove144 Foxglove144 commented Jul 2, 2023

Description

Replaced the import statement from scipy.ndimage.filters import median_filter with from scipy.ndimage import median_filter.

Fixes # (issue)

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • Test A
  • Test B

Test Configuration:

  • OS
  • Python version
  • ART version or commit number
  • TensorFlow / Keras / PyTorch / MXNet version

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Arunabh <arunabhm@protonmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2023

Codecov Report

Merging #2211 (c2b35c0) into main (bc39091) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2211   +/-   ##
=======================================
  Coverage   85.62%   85.62%           
=======================================
  Files         308      308           
  Lines       27448    27448           
  Branches     5044     5044           
=======================================
  Hits        23502    23502           
  Misses       2667     2667           
  Partials     1279     1279           
Impacted Files Coverage Δ
art/defences/preprocessor/spatial_smoothing.py 100.00% <100.00%> (ø)

@beat-buesser beat-buesser self-requested a review July 4, 2023 10:14
@beat-buesser beat-buesser self-assigned this Jul 4, 2023
@beat-buesser beat-buesser added the improvement Improve implementation label Jul 4, 2023
@beat-buesser beat-buesser changed the base branch from main to dev_1.15.1 July 4, 2023 10:22
Copy link
Collaborator

@beat-buesser beat-buesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Foxglove144 Thank you very much for fixing this deprecation warning!

@beat-buesser beat-buesser merged commit 3585836 into Trusted-AI:dev_1.15.1 Jul 4, 2023
37 checks passed
@Foxglove144 Foxglove144 deleted the patch-1 branch July 4, 2023 21:08
@beat-buesser beat-buesser added this to the ART 1.15.1 milestone Jul 4, 2023
@beat-buesser beat-buesser added this to Pull request done in ART 1.15.1 Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve implementation
Projects
No open projects
ART 1.15.1
Pull request done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants