Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for arbitrary-shaped input in APGD and ACG attacks #2214

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

beat-buesser
Copy link
Collaborator

Description

This pull request removes assumptions of input shape in APGD and ACG evasion attacks.

Fixes #2165

…t and AutoConjugateGradient

Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@beat-buesser beat-buesser self-assigned this Jul 4, 2023
@beat-buesser beat-buesser added bug Something isn't working improvement Improve implementation labels Jul 4, 2023
@beat-buesser beat-buesser added this to the ART 1.15.1 milestone Jul 4, 2023
@beat-buesser beat-buesser linked an issue Jul 4, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Merging #2214 (7aa1f1b) into dev_1.15.1 (c6da8c4) will increase coverage by 8.97%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@              Coverage Diff               @@
##           dev_1.15.1    #2214      +/-   ##
==============================================
+ Coverage       76.63%   85.61%   +8.97%     
==============================================
  Files             308      308              
  Lines           27450    27450              
  Branches         5045     5045              
==============================================
+ Hits            21036    23500    +2464     
+ Misses           5227     2669    -2558     
- Partials         1187     1281      +94     
Files Changed Coverage Δ
art/attacks/evasion/auto_conjugate_gradient.py 86.52% <100.00%> (ø)
...attacks/evasion/auto_projected_gradient_descent.py 86.51% <100.00%> (ø)

... and 40 files with indirect coverage changes

@beat-buesser beat-buesser changed the base branch from dev_1.15.1 to dev_1.15.0 August 9, 2023 12:44
@beat-buesser beat-buesser changed the base branch from dev_1.15.0 to dev_1.15.1 August 9, 2023 12:44
@beat-buesser beat-buesser added this to Pull request review in ART 1.15.1 Aug 10, 2023
@beat-buesser beat-buesser changed the base branch from dev_1.15.1 to dev_1.14.0 August 10, 2023 12:48
@beat-buesser beat-buesser changed the base branch from dev_1.14.0 to dev_1.15.1 August 10, 2023 12:48
Copy link
Collaborator

@Zaid-Hameed Zaid-Hameed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Beat for the changes!

@beat-buesser beat-buesser merged commit 509e223 into dev_1.15.1 Aug 16, 2023
71 checks passed
ART 1.15.1 automation moved this from Pull request review to Pull request done Aug 16, 2023
@beat-buesser beat-buesser deleted the development_issue_2165 branch August 16, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement Improve implementation
Projects
No open projects
ART 1.15.1
Pull request done
Development

Successfully merging this pull request may close these issues.

ACG and APGD loss runtime error with single sample
3 participants