Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PIL an optional dependency #2240

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Conversation

beat-buesser
Copy link
Collaborator

@beat-buesser beat-buesser commented Aug 10, 2023

Description

This pull request makes PIL and optional dependency again.

Fixes #2239

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Signed-off-by: Beat Buesser <bbu@aboyne.zrl.ch.ibm.com>
@beat-buesser beat-buesser self-assigned this Aug 10, 2023
@beat-buesser beat-buesser added bug Something isn't working improvement Improve implementation labels Aug 10, 2023
@beat-buesser beat-buesser added this to Pull request open in ART 1.15.1 via automation Aug 10, 2023
@beat-buesser beat-buesser added this to the ART 1.15.1 milestone Aug 10, 2023
@beat-buesser beat-buesser changed the base branch from main to dev_1.15.1 August 10, 2023 12:16
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #2240 (38618ca) into dev_1.15.1 (4cd5dc0) will increase coverage by 5.69%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@              Coverage Diff               @@
##           dev_1.15.1    #2240      +/-   ##
==============================================
+ Coverage       79.92%   85.62%   +5.69%     
==============================================
  Files             308      308              
  Lines           27448    27448              
  Branches         5044     5044              
==============================================
+ Hits            21938    23502    +1564     
+ Misses           4240     2667    -1573     
- Partials         1270     1279       +9     
Files Changed Coverage Δ
...cks/poisoning/perturbations/image_perturbations.py 93.58% <100.00%> (ø)
art/visualization.py 90.47% <100.00%> (ø)

... and 52 files with indirect coverage changes

Copy link
Collaborator

@f4str f4str left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks! I've tested it locally and everything still works without any issues.

@beat-buesser beat-buesser merged commit c7f0a4a into dev_1.15.1 Aug 11, 2023
71 checks passed
ART 1.15.1 automation moved this from Pull request open to Pull request done Aug 11, 2023
@beat-buesser beat-buesser deleted the development_issue_2239 branch August 11, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement Improve implementation
Projects
No open projects
ART 1.15.1
Pull request done
Development

Successfully merging this pull request may close these issues.

Remove unintended required dependency on PIL
3 participants