Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picklability #68

Merged
merged 20 commits into from
May 16, 2019
Merged

Picklability #68

merged 20 commits into from
May 16, 2019

Conversation

minhitbk
Copy link
Collaborator

I have included the picklability of TF and Pytorch in the pickle branch, also the issue of session conflict in tensorflow_unittest is solved.

Irina Nicolae and others added 18 commits April 1, 2019 15:09
Changes:
  - Add boundary and ZOO attacks
  - Fix segmentation fault on Travis
  - Update Travis config to not use sudo

Conflicts:
	docs/modules/attacks.rst
Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>
(cherry picked from commit 0294a35)
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
@ririnicolae ririnicolae self-requested a review May 15, 2019 12:25
@ririnicolae ririnicolae self-assigned this May 15, 2019
@ririnicolae
Copy link
Collaborator

@minhitbk Could you merge recent changes from dev to your branch? It currently has conflicts preventing Travis build. Thanks!

Copy link
Collaborator

@ririnicolae ririnicolae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@minhitbk Code looks good to me! Thanks for implementing pickling for TF and PyTorch. We're ready to merge this once the build is done.

@ririnicolae
Copy link
Collaborator

@minhitbk Some of the pickle tests are failing on Travis, could you take a look at those?

@ririnicolae ririnicolae merged commit aeb6757 into dev May 16, 2019
@ririnicolae ririnicolae deleted the pickle branch June 2, 2019 19:35
aabobakr pushed a commit to aabobakr/adversarial-robustness-toolbox that referenced this pull request Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants