Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ART to feature vectors #69

Merged
merged 24 commits into from May 16, 2019
Merged

Extend ART to feature vectors #69

merged 24 commits into from May 16, 2019

Conversation

ririnicolae
Copy link
Collaborator

Description

This PR extends ART to feature vectors. clip_values are now optional in classifiers. Clipping is only performed when these values are present. Constraints for images shapes have been removed. Attacks and defences were adapted to more general data shapes. Some attacks and defences that can only be applied on images now raise an error if a different data shape is provided. All these changes were tested on the Iris dataset with a small neural network model.

Closes #49

Type of change

Please check all relevant options.

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

  • Add trained Iris models for testing and code for loading them
  • Add unit tests for attacks, classifiers, wrappers and defences using Iris dataset

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@beat-buesser beat-buesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ririnicolae Your code looks great! I found 3 newly commented lines, could we remove them?

art/attacks/virtual_adversarial.py Outdated Show resolved Hide resolved
art/attacks/virtual_adversarial.py Outdated Show resolved Hide resolved
art/attacks/virtual_adversarial.py Outdated Show resolved Hide resolved
@ririnicolae
Copy link
Collaborator Author

@beat-buesser Thanks for the review and for noticing those comments, I have removed them now!

@beat-buesser beat-buesser merged commit 838b18b into dev May 16, 2019
@ririnicolae ririnicolae deleted the feat_vectors branch May 16, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants