Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull request template #763

Merged
merged 3 commits into from Oct 23, 2018
Merged

Add pull request template #763

merged 3 commits into from Oct 23, 2018

Conversation

sionelt
Copy link
Contributor

@sionelt sionelt commented Oct 23, 2018

Proposed Changes

  • add pull request template

Testing Instructions

  • No test needed.

Fixes #757


*

#### Fixes \#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should've this been just #, not \#?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the backslash escapes the heading hashes in front else the last hash won't show. I now see that can be confusing. I'll update it to just Fixes #

@simison
Copy link
Contributor

simison commented Oct 23, 2018

Thanks!

@simison simison merged commit 1840ab1 into Trustroots:master Oct 23, 2018
@sionelt sionelt deleted the add-pull-request-template branch October 23, 2018 19:31
trmendes pushed a commit to trmendes/trustroots that referenced this pull request Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants