Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login: make signup button at login page more prominent #891

Closed
wants to merge 1 commit into from

Conversation

copyhold
Copy link
Contributor

@copyhold copyhold commented Nov 27, 2018

make sign up button bigger

Resolves #889

Proposed Changes

  • change button class

Testing Instructions

  • uses built in bootstrap

Fixes #

  • small button

@simison simison changed the title Update signin.client.view.html Make signin button at login page more prominent Nov 27, 2018
@simison simison changed the title Make signin button at login page more prominent Login: make signin button at login page more prominent Nov 27, 2018
@simison
Copy link
Contributor

simison commented Nov 27, 2018

Thanks!

btn-info blue is reserved for a semantically different use. It's also a pity to have these two buttons in different sizes.

How about btn btn-default to both "back home" and "become a member"?

Before After
imageimage

I tested with btn-lg as well but then they start competing quite a bit with "login" button which isn't ideal:

image

@copyhold
Copy link
Contributor Author

become a member and back home should not be on same level of importance.

@copyhold
Copy link
Contributor Author

What do you think about this

image

@simison
Copy link
Contributor

simison commented Nov 27, 2018

Nice, thanks for designing!

Considering this is a login page, I'd be a bit worried to have those two buttons so similar and close to each other.

This isn't really the page to drive signups neither, our frontpage drives that purpose:

image

What do you think about removing the signup link completely from here? cc @guaka

@guaka
Copy link
Contributor

guaka commented Nov 27, 2018 via email

@simison
Copy link
Contributor

simison commented Nov 27, 2018

It does drive members: if someone who's not logged in opens a link to Trustroots profile they end up on this page So better make it part of the sign-up funnel

Valid point! That was probably my original reasoning to add it.

We have these landing pages for tribe and search pages:

screenshot 2018-11-27 at 20 52 00

screenshot 2018-11-27 at 20 51 32

Should we rather drive even more signups via profile pages with something like that? Any other authentication-restricted pages where users are likely to land?

We should still change the signup button at this page to be more prominent but not bombard the experience for those who are actually just trying to login.

@guaka guaka changed the title Login: make signin button at login page more prominent Login: make signup button at login page more prominent Nov 27, 2018
@copyhold
Copy link
Contributor Author

Better like this?
image

@simison
Copy link
Contributor

simison commented Nov 28, 2018

Looks good! How does it look on mobile?

@copyhold
Copy link
Contributor Author

I think it will fit the mobile without change layout.

@guaka
Copy link
Contributor

guaka commented Nov 29, 2018 via email

@simison
Copy link
Contributor

simison commented Nov 29, 2018

@guaka the changes are not actually in the branch yet.

👍 for your design @copyhold — feel free to implement it. :-)

copyhold added a commit to copyhold/trustroots that referenced this pull request Dec 8, 2018
Login: make signup button at login page more prominent Trustroots#891 
as a solution to [this](Trustroots#891)
@petr-hajek petr-hajek closed this Dec 11, 2018
petr-hajek pushed a commit that referenced this pull request Dec 13, 2018
* Update signin.client.view.html

Login: make signup button at login page more prominent #891 
as a solution to [this](#891)

* Update signin.client.view.html

moved comment line 
hide duplicate sign up and back buttons from mobile.

* Update authentication.less

make signup button more visible on aurora background

* Update signin.client.view.html

make signup button more visible on aurora background

* Update signin.client.view.html

typo in class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants