.travis.yml: NODE_ENV=production #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#910 NODE_ENV=production
mrkvon
reviewed
Dec 4, 2018
simison
reviewed
Dec 4, 2018
simison
approved these changes
Dec 4, 2018
There was a problem hiding this comment.
Looks good:
https://travis-ci.org/Trustroots/trustroots/jobs/463530519#L663
We can loop back later to combine build and lint tasks into same container. That would save some time on CI, since lint is super fast task and most of the time is spent on spinning up the container in Travis.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#910 NODE_ENV=production
Proposed Changes
Testing Instructions
Fixes #910