New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin search users #960

Merged

simison merged 34 commits into master from admin

May 11, 2019

Contributor

guaka commented Dec 12, 2018 •

edited by simison

Proposed Changes

First /admin stuff: /admin/search-users, using the users?search=query endpoint
Adds requireRole to angular stuff

Testing Instructions

add admin to your test user's roles
go to http://localhost:3000/admin

Relates to #857, #530

Next steps:

create admin API endpoint on server that searches on emails, and returns emails
/api/admin/users should only be accessible by admin users - ensure with a test
use onSubmit instead of onChange or use debounce
show recent down-voted threads
show how new people heard about trustroots At sign-up: how did you hear about Trustroots? #879

(still nice to already merge this before next deployment to prod)

guaka requested a review from simison

December 12, 2018 23:13

simison reviewed

View reviewed changes

modules/core/client/controllers/app.client.controller.js Show resolved Hide resolved

simison reviewed

View reviewed changes

modules/admin/client/config/admin.client.routes.js Outdated Show resolved Hide resolved

simison reviewed

View reviewed changes

modules/admin/client/components/search.api.js Outdated Show resolved Hide resolved

simison reviewed

View reviewed changes

modules/admin/client/components/search.api.js Outdated Show resolved Hide resolved

simison reviewed

View reviewed changes

modules/admin/client/components/AdminSearchUsers.component.js Outdated Show resolved Hide resolved

simison reviewed

View reviewed changes

modules/admin/client/components/AdminSearchUsers.component.js Outdated Show resolved Hide resolved

simison reviewed

View reviewed changes

modules/admin/client/components/Admin.component.js Outdated Show resolved Hide resolved

mrkvon added admin labels

Akronix mentioned this pull request

Add search api query #984

Merged

guaka mentioned this pull request

Improve Search User API #944

Closed

3 tasks

simison force-pushed the admin branch from f26cd40 to a78de18 Compare

May 11, 2019 12:40

Kasper Souren and others added 17 commits

May 12, 2019 00:14


          not working

9654b80


          fix: wire in admin module, cleanup

fcdb1ff


          /admin for users with role admin

b880ebf


          attempt at adding AdminSearchUsers, requiresRole implies requiresAuth

2122a5e


          working search at /admin/search-users

e9c2fdf


          input type search

efe5a81


          container-spacer, link back to /admin

60ec359


          better comments

39598bb


          Wanna help us build Trustroots?

67ff765


          lint;

f47c27c


          link to github issue from /admin

331f74a


          creating server side admin routes

46b984a


          search by regexp, and by email


          Add files to ES6 whitelist

01b8e47


          Work on backend

d6b3e9a

- separate getUser (by ID) from searching multiple users
- rename controller from "profile" to "user" to match module
- tidy  up here and there
- ES6 JS syntax


          Add policy to limit non-admin users

204690c


          Add API tests

e388659

simison added 17 commits

May 12, 2019 00:14


          Work on client

2d2baae

- Move client API file to api folder from components
- replace fetch with axios in api
- Add header/navigation component for admin section
- general tidying up


          Elaborate access error a bit

4ef19a3


          Fix import

cd13ae6


          Work on client

502daf8


          Nicer icons


          Escape regexp

06794f2


          Debounce onChange

bbdbd6a


          Improved labels

605a17a


          Use POST instead of GET as a security measure

f5af2af


          rename some vars

c63c32d


          Simplify & more secure handling of tokens

6b57b9b


          Populate tribe info

dac719a


          Disable analytics for admin dash

952f971


          Remove debounce, it messes up something with client side testing...

9bbdfed


          Handle temporary emails in the list

7cb6adf


          Remove suspended-highlighting with background color

68e2c08

...it conflicts with every 2nd different row color


          Workaround onChange API load with onSubmit instead

ea072f1

simison force-pushed the admin branch from b0bdae0 to ea072f1 Compare

May 11, 2019 23:37

simison merged commit a746ad1 into master

simison deleted the admin branch

May 11, 2019 23:44

Akronix mentioned this pull request

Master issue for search members frontend #1152

Closed

5 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment