Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save user's locale to database (API) #962

Merged
merged 2 commits into from Dec 15, 2018
Merged

Save user's locale to database (API) #962

merged 2 commits into from Dec 15, 2018

Conversation

mrkvon
Copy link
Contributor

@mrkvon mrkvon commented Dec 13, 2018

Proposed Changes

  • add locale to user model via PUT /api/users with body { locale: 'eng', ... }

Testing Instructions

  • npm run test:server:watch

Continued work on #492

@mrkvon mrkvon changed the title save locale to user Save locale to user Dec 13, 2018
@mrkvon mrkvon added the i18n label Dec 13, 2018
@mrkvon mrkvon changed the title Save locale to user Save user's locale to database (API) Dec 13, 2018
simison
simison approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@simison simison left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests as described 👍

I tested that locale persists as expected when updating other profile content via the site.

I love these small focused PRs :-)

@mrkvon mrkvon merged commit ffca3ec into master Dec 15, 2018
@simison simison deleted the change-locale-api branch December 16, 2018 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simison simison simison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrkvon @simison