Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Commit

Permalink
✍ Change contributors on about page to be manually (#330)
Browse files Browse the repository at this point in the history
refs TryGhost/Ghost#7427

Removes `-contributors.hbs` and `public/assets/img/contributors` from `.gitignore`.
Removes `buildAboutPage` from `grunt init` task.
Updates `contributors.hbs` and adds images for each contributor.
Changes the `max-width` of `.gh-credits` wrapper to be 700px instead of 650px, so we'll fit them all in two rows.
  • Loading branch information
aileen authored and kevinansfield committed Oct 17, 2016
1 parent 05581f0 commit 928d9d4
Show file tree
Hide file tree
Showing 24 changed files with 102 additions and 6 deletions.
4 changes: 0 additions & 4 deletions .gitignore
Expand Up @@ -49,7 +49,3 @@ Session.vim
/libpeerconnection.log
npm-debug.log
testem.log

# built by grunt
public/assets/img/contributors/
app/templates/-contributors.hbs
2 changes: 1 addition & 1 deletion Gruntfile.js
Expand Up @@ -143,7 +143,7 @@ module.exports = function(grunt) {
});

grunt.registerTask('init', 'Install the client dependencies',
['shell:npm-install', 'shell:bower-install', 'buildAboutPage']
['shell:npm-install', 'shell:bower-install']
);

grunt.registerTask('lint', 'Run the code style checks and linter',
Expand Down
2 changes: 1 addition & 1 deletion app/styles/layouts/about.css
Expand Up @@ -44,7 +44,7 @@

.gh-credits {
margin: 2em 0;
max-width: 650px;
max-width: 700px;
color: var(--midgrey);
font-size: 1.8rem;
font-weight: 200;
Expand Down
100 changes: 100 additions & 0 deletions app/templates/-contributors.hbs
@@ -0,0 +1,100 @@
<article>
<a href="https://github.com/JohnONolan" title="JohnONolan">
<img src="{{gh-path "asset" "/img/contributors"}}/JohnONolan.jpeg" alt="JohnONolan" />
</a>
</article>
<article>
<a href="https://github.com/ErisDS" title="ErisDS">
<img src="{{gh-path "asset" "/img/contributors"}}/ErisDS.jpeg" alt="ErisDS" />
</a>
</article>
<article>
<a href="https://github.com/sebgie" title="sebgie">
<img src="{{gh-path "asset" "/img/contributors"}}/sebgie.png" alt="sebgie" />
</a>
</article>
<article>
<a href="https://github.com/frantzypants" title="frantzypants">
<img src="{{gh-path "asset" "/img/contributors"}}/frantzypants.jpeg" alt="frantzypants" />
</a>
</article>
<article>
<a href="https://github.com/cobbspur" title="cobbspur">
<img src="{{gh-path "asset" "/img/contributors"}}/cobbspur.jpeg" alt="cobbspur" />
</a>
</article>
<article>
<a href="https://github.com/kevinansfield" title="kevinansfield">
<img src="{{gh-path "asset" "/img/contributors"}}/kevinansfield.jpeg" alt="kevinansfield" />
</a>
</article>
<article>
<a href="https://github.com/GeorginaLusby" title="GeorginaLusby">
<img src="{{gh-path "asset" "/img/contributors"}}/GeorginaLusby.jpeg" alt="GeorginaLusby" />
</a>
</article>
<article>
<a href="https://github.com/AileenCGN" title="AileenCGN">
<img src="{{gh-path "asset" "/img/contributors"}}/AileenCGN.jpeg" alt="AileenCGN" />
</a>
</article>
<article>
<a href="https://github.com/kirrg001" title="kirrg001">
<img src="{{gh-path "asset" "/img/contributors"}}/kirrg001.jpeg" alt="kirrg001" />
</a>
</article>
<article>
<a href="https://github.com/disordinary" title="disordinary">
<img src="{{gh-path "asset" "/img/contributors"}}/disordinary.jpeg" alt="disordinary" />
</a>
</article>
<article>
<a href="https://github.com/acburdine" title="acburdine">
<img src="{{gh-path "asset" "/img/contributors"}}/acburdine.jpeg" alt="acburdine" />
</a>
</article>
<article>
<a href="https://github.com/dbalders" title="dbalders">
<img src="{{gh-path "asset" "/img/contributors"}}/dbalders.jpeg" alt="dbalders" />
</a>
</article>
<article>
<a href="https://github.com/felixrieseberg" title="felixrieseberg">
<img src="{{gh-path "asset" "/img/contributors"}}/felixrieseberg.jpeg" alt="felixrieseberg" />
</a>
</article>
<article>
<a href="https://github.com/jaswilli" title="jaswilli">
<img src="{{gh-path "asset" "/img/contributors"}}/jaswilli.jpeg" alt="jaswilli" />
</a>
</article>
<article>
<a href="https://github.com/halfdan" title="halfdan">
<img src="{{gh-path "asset" "/img/contributors"}}/halfdan.jpeg" alt="halfdan" />
</a>
</article>
<article>
<a href="https://github.com/kevinkucharczyk" title="kevinkucharczyk">
<img src="{{gh-path "asset" "/img/contributors"}}/kevinkucharczyk.jpeg" alt="kevinkucharczyk" />
</a>
</article>
<article>
<a href="https://github.com/mixonic" title="mixonic">
<img src="{{gh-path "asset" "/img/contributors"}}/mixonic.png" alt="mixonic" />
</a>
</article>
<article>
<a href="https://github.com/rwjblue" title="rwjblue">
<img src="{{gh-path "asset" "/img/contributors"}}/rwjblue.jpeg" alt="rwjblue" />
</a>
</article>
<article>
<a href="https://github.com/tgriesser" title="tgriesser">
<img src="{{gh-path "asset" "/img/contributors"}}/tgriesser.png" alt="tgriesser" />
</a>
</article>
<article>
<a href="https://github.com/bnookala" title="bnookala">
<img src="{{gh-path "asset" "/img/contributors"}}/bnookala.jpeg" alt="bnookala" />
</a>
</article>
Binary file added public/assets/img/contributors/AileenCGN.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/assets/img/contributors/ErisDS.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/assets/img/contributors/GeorginaLusby.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/assets/img/contributors/JohnONolan.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/assets/img/contributors/acburdine.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/assets/img/contributors/bnookala.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/assets/img/contributors/cobbspur.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/assets/img/contributors/dbalders.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/assets/img/contributors/disordinary.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/assets/img/contributors/frantzypants.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/assets/img/contributors/halfdan.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/assets/img/contributors/jaswilli.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/assets/img/contributors/kevinansfield.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/assets/img/contributors/kirrg001.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/assets/img/contributors/mixonic.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/assets/img/contributors/rwjblue.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/assets/img/contributors/sebgie.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/assets/img/contributors/tgriesser.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 928d9d4

Please sign in to comment.