This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Remove outdated Ghost-Desktop client check #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunaticmonk
changed the title
lunaticmonk
force-pushed
the
remove-check
branch
from
9843304
to
1f8ab66
Compare
kevinansfield
suggested changes
Sep 24, 2018
| @@ -50,16 +50,6 @@ describe('Acceptance: Ghost Desktop', function () { | |||
| restoreUserAgent(); | |||
| }); | |||
|
|
|||
| it('displays alert for broken version', async function () { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
lunaticmonk
force-pushed
the
remove-check
branch
from
1f8ab66
to
82c1cba
Compare
|
@kevinansfield Please revieew. |
|
@kevinansfield Is the pr okay? Or do I need to maintain the code coverage here? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got some code for us? Awesome 馃帄!
Fixes TryGhost/Ghost#9895
Please include a description of your change & check your PR against this list, thanks!
ember testfrom the repo root - will becore/clientif working from the submodule in Ghost).