This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Added image validation error message to gallery card #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhgrg
commented
Sep 24, 2018
rishabhgrg
force-pushed
the
gallery-card-validation-error
branch
from
c43406b
to
03ccfe4
Compare
rishabhgrg
force-pushed
the
gallery-card-validation-error
branch
from
03ccfe4
to
e02ee78
Compare
rishabhgrg
force-pushed
the
gallery-card-validation-error
branch
from
e02ee78
to
b439a36
Compare
closes TryGhost/Ghost#9840 - added error on uploading an invalid image format - updated to use overall error method(`onFailed`) to set error message instead of individual upload failures(`onUploadFailure`)
rishabhgrg
force-pushed
the
gallery-card-validation-error
branch
from
b439a36
to
014f801
Compare
Co-Authored-By: rishabhgrg <zrishabhgarg@gmail.com>
kevinansfield
approved these changes
Nov 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes TryGhost/Ghost#9840
onFailed) to set error message as well as individual upload failures(onUploadFailure)