This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
startDateLabel populated #1644
Merged
startDateLabel populated #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinansfield
suggested changes
Jul 21, 2020
app/components/gh-members-chart.js
Outdated
Comment on lines
21
to
22
| startDateLabel: computed('membersStats.days', function () { | ||
| return moment(new Date()).add(-this.membersStats.days + 1, 'days').format(DATE_FORMAT); |
There was a problem hiding this comment.
Unfortunately this won't work when the "All time" range is chosen because memberStats.days will be "all-time" and not a number.
What you could do instead is to use memberStats.stats as the dependent key and use Object.keys(memberStats.stats.total_on_date)[0] to grab the first date in the range and build the label from there.
There was a problem hiding this comment.
ahh, thank you for that!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12014
-startDateLabel variable populated in order to show start date for the members chart.
ember testfrom the repo root - will becore/clientif working from the submodule in Ghost).More info can be found by clicking the "guidelines for contributing" link above.