This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Added open-rate column to the members list #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
- added `{{feature "flag"}}` helper so feature flags can be checked in templates without injecting the feature service into the backing class
- added `emailOpenRate` property to member model
- added `order` query param to the members controller/route and wired it into the data fetching routine
- added order dropdown to the filter bar with "Newest" (default) and "Open rate" as the two options
- whole dropdown is hidden if email analytics is disabled
- hid the open rate column when email analytics is disabled
- show open rate when it's available, otherwise show a `–` with a title to indicate insufficient data
kevinansfield
force-pushed
the
members-list-stats
branch
from
724bb67
to
bb8187f
Compare
allouis
added a commit
to allouis/Ghost-Admin
that referenced
this pull request
Dec 9, 2020
* upstream/master: (24 commits) ✨ Added open-rate column and ordering to the members list (TryGhost#1790) v3.39.3 🐛 Fixed email design settings not opening 🐛 Fixed email design settings not opening v3.39.2 v3.39.1 Fixed email cards missing an edit icon in the toolbar Fixed copy for open-tracking settings Update dependency eslint to v7.15.0 Moved email open rate ordering behind analytics flag Added open rate order option to posts list Lock file maintenance (TryGhost#1787) Update dependency ember-auto-import to v1.8.0 (TryGhost#1789) Fixed email cards missing an edit icon in the toolbar Fixed copy for open-tracking settings v3.39.0 Email settings preview refinements (TryGhost#1788) Added emailAnalytics feature flag 🐛 Fixed infinite spinner when admin login attempt fails (TryGhost#1755) Lock file maintenance ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No-ref