This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
✨ Added new members CSV importer #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-issue We are rewriting the Members CSV importer to use background jobs along with foreground import, this commit sets up UI base for new importer Reorders action and set UPLOADING state Fixed CSV fields mapper Improved UI for foreground imports Updated foreground process UI to allow downloading CSV Updated error UI Updated small import final screen MVP Updated processing screen
no issue Updates UI for background import processing Updated GhMemberLabelInput to not use mutable state no-issue - Also refactors to be a Glimmer component - Passing mutable state from Glimmers components is tricky, so this makes it easier to work with. Update Member settings to work with GhMemberLabelInput Fixed labels being set on mappingResult Fixed custom labels being set on import Updated styles Fixed willDestroy for GhMemberLabelInput Added error list in upload complete modal
no issues Uses members-csv module to generate CSV with any import errors locally Cleaned up error messages list Updated error handling Fixed error display for csv mapping Fixed error displaying after mapping updated Added border to table Updated ImportTable to wait for render before updating parent Updated csv-mapper to only show errors when error exists Handled showMappingErrors in reset Updated error list style Fix tests Fixed mapping format in formData Added drag drop event for CSV upload Adjust animation speed Fixed modal-import test Updated @tryghost/members-csv to 0.4.0 Updated drag events on upload element Updated finish screens Updated spinner style Updated typography Removed drag tests for members import modal Fixed lint Update dependency autoprefixer to v10.0.4 (TryGhost#1785) Co-authored-by: Renovate Bot <bot@renovateapp.com> Update dependency ember-auto-import to v1.8.0 (TryGhost#1789) Co-authored-by: Renovate Bot <bot@renovateapp.com> Added open rate order option to posts list closes TryGhost/Ghost#12420 - adds "Open rate" to the available ordering options in the posts list order dropdown - amends pages controller to have it's own order list because pages can't be ordered by open rate Moved email open rate ordering behind analytics flag refs TryGhost/Ghost#12420 - email analytics can be disabled, when that's the case it doesn't make sense to allow posts to be sorted by open rate Udpated no members finish screen Updated too long note error copy Updated uploading screen Fixed jumping spinner on import progress step Updated uploading screen Improved error csv name Fixed import order Added error translation
no-issue This is so that we don't automatically trigger a background job Fixed empty CSV stuck on loader Updated error handling in CSV and list no refs - Updated errors in list to use common replacement pattern - Updates errors in CSV to use same replacement pattern for standard error messages Updated mapping test to remove stripe id
rishabhgrg
force-pushed
the
final-member-importer-update
branch
2 times, most recently
from
f1540a1
to
32238e2
Compare
rishabhgrg
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds UI handling for members CSV import