This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
馃悰 Remove empty benefits before saving #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Todo: add a test for this behaviour |
SimonBackx
force-pushed
the
fix/empty-benefits
branch
from
287ae8a
to
63672c6
Compare
|
@matthanley Test is added 馃槉 |
matthanley
approved these changes
Mar 4, 2022
SimonBackx
force-pushed
the
fix/empty-benefits
branch
from
63672c6
to
4319dd5
Compare
refs https://github.com/TryGhost/Team/issues/1188 - The api throws a validation error when we try to add benefits with an empty name - Before saving, we remove benefits with an empty name
SimonBackx
force-pushed
the
fix/empty-benefits
branch
from
4319dd5
to
c2fec02
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://github.com/TryGhost/Team/issues/1188