This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Added shortcut buttons to "Last seen" members filter datepicker #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost/Product#1410 - added block invocation support to `<GhDatePicker>` that exposes the calendar components used inside the datepicker dropdown allowing for customisation of the dropdown content - updated "last seen" datepicker to use the block invocation support to add buttons that select typical "time ago" dates
Codecov Report
@@ Coverage Diff @@
## main #2291 +/- ##
=======================================
Coverage 41.18% 41.19%
=======================================
Files 579 579
Lines 22779 22782 +3
Branches 4028 4030 +2
=======================================
+ Hits 9382 9384 +2
- Misses 13397 13398 +1
Continue to review full report at Codecov.
|
kevinansfield
added a commit
to kevinansfield/Ghost-Admin
that referenced
this pull request
Mar 8, 2022
…cuts closes TBD - drops the block usage of `<GhDatePicker>` for the "Last seen" input that added shortcut buttons - not a full revert of TryGhost#2291 as allowing block usage of the component is still useful for other component customisation - removes CSS related to the calendar-with-shortcut buttons as we don't have any other use-cases for it at the moment
kevinansfield
added a commit
to kevinansfield/Ghost-Admin
that referenced
this pull request
Mar 8, 2022
…cuts refs TryGhost/Product#1418 - drops the block usage of `<GhDatePicker>` for the "Last seen" input that added shortcut buttons - not a full revert of TryGhost#2291 as allowing block usage of the component is still useful for other component customisation - removes CSS related to the calendar-with-shortcut buttons as we don't have any other use-cases for it at the moment
kevinansfield
added a commit
that referenced
this pull request
Mar 8, 2022
…cuts (#2296) refs TryGhost/Product#1418 - drops the block usage of `<GhDatePicker>` for the "Last seen" input that added shortcut buttons - not a full revert of #2291 as allowing block usage of the component is still useful for other component customisation - removes CSS related to the calendar-with-shortcut buttons as we don't have any other use-cases for it at the moment
tigefa4u
pushed a commit
to tigefa4u/Ghost
that referenced
this pull request
Aug 3, 2022
…cuts (TryGhost#2296) refs TryGhost/Product#1418 - drops the block usage of `<GhDatePicker>` for the "Last seen" input that added shortcut buttons - not a full revert of TryGhost/Admin#2291 as allowing block usage of the component is still useful for other component customisation - removes CSS related to the calendar-with-shortcut buttons as we don't have any other use-cases for it at the moment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://github.com/TryGhost/Team/issues/1410
<GhDatePicker>that exposes the calendar components used inside the datepicker dropdown allowing for customisation of the dropdown content