Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

🐛 fix missing meta description preview #719

Merged
merged 1 commit into from May 30, 2017

Conversation

kevinansfield
Copy link
Collaborator

refs #718, TryGhost/Ghost#8305

  • meta description preview in the PSM was relying on the html field which is no longer queried - see 🎨 use formats query param #718 and ✨ Add ?formats param to Posts API Ghost#8305
  • restores live preview that was in LTS but removed whilst implementing mobiledoc because we had no quick way of rendering mobiledoc->text
  • adds a boolean argument to the formatMarkdown util that can disable the replacement of <script> and <iframe> tags so that the inserted text isn't rendered when converting HTML to text

refs TryGhost#718, TryGhost/Ghost#8305
- meta description preview in the PSM was relying on the `html` field which is no longer queried - see TryGhost#718 and TryGhost/Ghost#8305
- restores live preview that was in LTS but removed whilst implementing mobiledoc because we had no quick way of rendering mobiledoc->text
- adds a boolean argument to the `formatMarkdown` util that can disable the replacement of `<script>` and `<iframe>` tags so that the inserted text isn't rendered when converting HTML to text
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 72.61% when pulling 59fd57c on kevinansfield:fix-meta-desc-preview into 221ca16 on TryGhost:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 72.61% when pulling 59fd57c on kevinansfield:fix-meta-desc-preview into 221ca16 on TryGhost:master.

Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Good catch!

@kirrg001 kirrg001 merged commit 3f2e802 into TryGhost:master May 30, 2017
@kevinansfield kevinansfield deleted the fix-meta-desc-preview branch June 4, 2018 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants