This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
⚡️ Add per-post code injection fields to post settings menu #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinansfield
changed the title
kevinansfield
force-pushed
the
per-post-code-injection
branch
from
9347108
to
ebc52ed
Compare
no issue The PSM was the only place where the `gh-tabs-manager`, `gh-tab`, and `gh-tab-pane` components were being used. These were very old components and did not work well with newer Ember versions and best practices. - 🔥 remove `gh-tab*` components - 💄 fix indents in `gh-post-settings-menu` template - 🎨 add support for named subviews ready for additional PSM panes
kirrg001
force-pushed
the
per-post-code-injection
branch
from
ebc52ed
to
e422598
Compare
kirrg001
changed the title
kevinansfield
force-pushed
the
per-post-code-injection
branch
from
e422598
to
3c84074
Compare
- add "Code Injection" pane to the PSM - implement `codeinjectionHead` and `codeinjectionFoot` attributes on `Post` model and save values from PSM - use CodeMirror for the PSM code injection fields
aileen
force-pushed
the
per-post-code-injection
branch
from
9630988
to
264b079
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs tbd, requires tbd
codeinjectionHeadandcodeinjectionFootattributes onPostmodel and save values from PSMTODO: