Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Prevent keymaster bindings from causing failed tests #976

Merged
merged 1 commit into from
Mar 19, 2018

Commits on Mar 19, 2018

  1. Prevent keymaster bindings from causing failed tests

    no issue
    - keymaster bindings could be kept around between tests with references to objects that should have been deleted. This was manifesting itself with a Tags acceptance test failing because one of the key binding tests triggered two actions, one on the route under test and another on a route that was kept around from a previous Error Handling acceptance test (previous test intentionally had an aborted transition so the action in the current test was complaining about the first transition not being complete)
    - add guard to ensure that shortcuts can't be registered multiple times on an object
    - remove all `default` scope keymaster bindings when destroying a test app instance
    kevinansfield committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    6f30b1d View commit details
    Browse the repository at this point in the history