Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Switch to packaged version of Spirit #985

Merged
merged 1 commit into from Apr 3, 2018

Conversation

kevinansfield
Copy link
Collaborator

@kevinansfield kevinansfield commented Mar 23, 2018

no issue

  • remove the manually copied Spirit CSS files
  • remove the manually copied Spirit helpers
  • install ember-cli-ghost-spirit addon
  • remove manual postcss configuration
  • update all color() functions in CSS to color-mod()
  • fixed invalid color-mod() usage in power-calendar.css
  • bump sub-dependencies

TODO:

  • implement emberified helpers in ember-cli-ghost-spirit and upgrade

@coveralls
Copy link

coveralls commented Mar 23, 2018

Coverage Status

Coverage remained the same at 72.225% when pulling 04b5396 on kevinansfield:muon-trap into 9f46299 on TryGhost:master.

no issue
- remove the manually copied Spirit CSS files
- remove the manually copied Spirit helpers
- install `ember-cli-ghost-spirit` addon
- remove manual postcss configuration
- update all `color()` functions in CSS to `color-mod()`
- fixed invalid `color-mod()` usage in `power-calendar.css`
- bump sub-dependencies
@kevinansfield kevinansfield changed the title [WIP] Switch to packaged version of Spirit Switch to packaged version of Spirit Apr 3, 2018
@kevinansfield kevinansfield merged commit a28eb92 into TryGhost:master Apr 3, 2018
@kevinansfield kevinansfield deleted the muon-trap branch April 3, 2018 10:52
kevinansfield added a commit that referenced this pull request Apr 3, 2018
no issue
- our custom `.kg-card-selected` and `.kg-media-placeholder` classes were removed in #985
- add them back in our 🛎🛎🛎 **shame** file until they make their way into Spirit
kevinansfield added a commit that referenced this pull request Apr 9, 2018
closes TryGhost/Ghost#9557
- #985 global search&replace missed multiple `color()` calls on the same line
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants