Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Commit

Permalink
🐛 fix flickering buttons during modal transitions (#710)
Browse files Browse the repository at this point in the history
no issue

- removes transition on `all` properties in favour of an explicit list, fixes the buttons flickering after the modal appears and the outline/text being visible when the modal disappears
- simplifies the liquid-fire transition so that elements being removed at slightly different times doesn't cause flickering when the modal is removed
  • Loading branch information
kevinansfield authored and kirrg001 committed May 23, 2017
1 parent 6e84106 commit b2c8db4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
1 change: 1 addition & 0 deletions app/styles/patterns/buttons.css
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
fill: color(var(--lightgrey) l(-27%) blackness(+15%));
border-radius: 5px;
transition: all 0.2s ease;
transition-property: color, border-color, background, width, height;

-webkit-font-smoothing: subpixel-antialiased;
}
Expand Down
7 changes: 1 addition & 6 deletions app/transitions.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,7 @@ export default function () {
this.hasClass('fullscreen-modal-container'),
this.toValue(true),
this.use('fade', {duration: 150}),
this.reverse('explode', {
pick: '.fullscreen-modal',
use: ['fade', {duration: 80}]
}, {
use: ['fade', {duration: 150}]
})
this.reverse('fade', {duration: 150})
);

this.transition(
Expand Down

0 comments on commit b2c8db4

Please sign in to comment.