This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Fix editor error handling #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinansfield
changed the title
closes TryGhost/Ghost#7099 - update editor base controller's `showErrorAlert` method to handle `AdapterError` or `AjaxError` objects - update PSM's error handling so that we don't pass an error object wrapped in an array to `showAPIError` - add missing title attribute to Mirage's Post factory - remove some leftover `console.log`s
kevinansfield
force-pushed
the
fix-post-error-handling
branch
from
c27bc98
to
e83cc6d
Compare
kevinansfield
changed the title
|
⚡️ready for review |
|
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes TryGhost/Ghost#7099
showErrorAlertmethod to handleAdapterErrororAjaxErrorobjectsshowAPIError(this was causing the default error message to always be displayed and the global version mismatch/maintenance mode handling to be skipped if an error was encountered when changing a value in the PSM triggered a save)console.logsTODO: