This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Added special message for "locked" users when they fail signin #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost/Ghost#11790 - After user fails to signin due to "locked" being locked a new view with automatic email message and more instructions will be shown to make the password reset process easier.
| @@ -55,6 +57,10 @@ export default Controller.extend(ValidationEngine, { | |||
|
|
|||
| this.set('flowErrors', (mainError.context.string || mainError.message.string)); | |||
|
|
|||
| if (mainError.message.string.match(/your password must be reset/i)) { | |||
There was a problem hiding this comment.
We should be switching on the PasswordResetRequiredError that should be available on mainError.type if possible - messaging can change so it's brittle to inspect the message string.
naz
added a commit
that referenced
this pull request
May 5, 2020
- Changed as per review here: #1560 (comment)
|
Was superseeded by #1561 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs TryGhost/Ghost#11790