This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Separate invites and users #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinansfield
changed the title
kevinansfield
changed the title
2 tasks
kevinansfield
force-pushed
the
invite-model
branch
2 times, most recently
from
feee8a2
to
c3566a4
Compare
kevinansfield
changed the title
kevinansfield
force-pushed
the
invite-model
branch
3 times, most recently
from
476cdf8
to
4327433
Compare
kevinansfield
changed the title
|
ready for review 馃槑 |
issue TryGhost/Ghost#7420, requires TryGhost/Ghost#7422 - adds a new `Invite` model with associated serializer and test setup - updates team screen to use invites rather than existing users with the "invited" property - updates signup process to work with new invite model - updates setup process to create invites instead of users - swaps usage of `gh-select-native` for `one-way-select` in the invite modal so that attributes can be set on the `select` element - updates resend invite process to account for server returning a new model - rewrites the invite management tests and fixes mirage mocks for invite endpoints - sorts invites by email address to avoid jumping invites when re-sending
kevinansfield
force-pushed
the
invite-model
branch
from
4327433
to
e115bbd
Compare
|
Have tested this and all the behaviour seems to be working as far as I can tell. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue TryGhost/Ghost#7420, requires TryGhost/Ghost#7422
Invitemodel with associated serializer and test setupgh-select-nativeforone-way-selectin the invite modal so that attributes can be set on theselectelementTODO: