Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract the separation of invites/users from OAuth spike #7420

Closed
2 tasks done
kevinansfield opened this issue Sep 21, 2016 · 0 comments
Closed
2 tasks done

Extract the separation of invites/users from OAuth spike #7420

kevinansfield opened this issue Sep 21, 2016 · 0 comments
Assignees
@kevinansfield
Milestone
1.0.0-alpha.2

Comments

@kevinansfield
Copy link
Contributor

kevinansfield commented Sep 21, 2016 •
edited by kirrg001
Loading

Whilst spiking the integration of the new centralised OAuth provider we also made changes to the data model by creating a separate Invite model rather than relying on partially-created user models.

This change is not directly related to the OAuth integration and will be easier to reason about and test when dealt with separately. Changes were required on both server and client so I propose creating new PRs for each that contain only the modifications needed for the data model change.
@kevinansfield kevinansfield mentioned this issue Sep 21, 2016
Merged
5 tasks
@kirrg001 kirrg001 added this to the 1.0.0-alpha.2 milestone Sep 21, 2016
@kirrg001 kirrg001 mentioned this issue Sep 21, 2016
Merged
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Sep 22, 2016
@kevinansfield
move to a separate Invite model
c3566a4 
issue TryGhost/Ghost#7420, requires TryGhost/Ghost#7422
- adds a new `Invite` model with associated serializer and test setup
- updates team screen to use invites rather than existing users with the "invited" property
- updates signup process to work with new invite model
- updates setup process to create invites instead of users
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Sep 22, 2016
@kevinansfield
move to a separate Invite model
88abd3a 
issue TryGhost/Ghost#7420, requires TryGhost/Ghost#7422
- adds a new `Invite` model with associated serializer and test setup
- updates team screen to use invites rather than existing users with the "invited" property
- updates signup process to work with new invite model
- updates setup process to create invites instead of users
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Sep 23, 2016
@kevinansfield
move to a separate Invite model
476cdf8 
issue TryGhost/Ghost#7420, requires TryGhost/Ghost#7422
- adds a new `Invite` model with associated serializer and test setup
- updates team screen to use invites rather than existing users with the "invited" property
- updates signup process to work with new invite model
- updates setup process to create invites instead of users
- swaps usage of `gh-select-native` for `one-way-select` in the invite modal so that attributes can be set on the `select` element
- updates resend invite process to account for server returning a new model
- rewrites the invite management tests and fixes mirage mocks for invite endpoints
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Sep 23, 2016
@kevinansfield
move to a separate Invite model
4327433 
issue TryGhost/Ghost#7420, requires TryGhost/Ghost#7422
- adds a new `Invite` model with associated serializer and test setup
- updates team screen to use invites rather than existing users with the "invited" property
- updates signup process to work with new invite model
- updates setup process to create invites instead of users
- swaps usage of `gh-select-native` for `one-way-select` in the invite modal so that attributes can be set on the `select` element
- updates resend invite process to account for server returning a new model
- rewrites the invite management tests and fixes mirage mocks for invite endpoints
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Sep 23, 2016
@kevinansfield
move to a separate Invite model
e115bbd 
issue TryGhost/Ghost#7420, requires TryGhost/Ghost#7422
- adds a new `Invite` model with associated serializer and test setup
- updates team screen to use invites rather than existing users with the "invited" property
- updates signup process to work with new invite model
- updates setup process to create invites instead of users
- swaps usage of `gh-select-native` for `one-way-select` in the invite modal so that attributes can be set on the `select` element
- updates resend invite process to account for server returning a new model
- rewrites the invite management tests and fixes mirage mocks for invite endpoints
- sorts invites by email address to avoid jumping invites when re-sending
kirrg001 added a commit to kirrg001/Ghost that referenced this issue Sep 26, 2016
@kirrg001
🎨 Separate invites from user
b79a18c 
refs TryGhost#7420
- remove invite logic from user
- add invite model and adapt affected logic for inviting team members
ErisDS added a commit that referenced this issue Sep 26, 2016
@ErisDS
Merge pull request #7422 from kirrg001/feature/users-invites-separation
6c24084 
🎨  Separate invites from user

refs #7420

- remove invite logic from user
- add invite model and adapt affected logic for inviting team members
mixonic pushed a commit to mixonic/Ghost that referenced this issue Oct 28, 2016
@kirrg001 @mixonic
🎨 Separate invites from user
e67c08b 
refs TryGhost#7420
- remove invite logic from user
- add invite model and adapt affected logic for inviting team members
geekhuyang pushed a commit to geekhuyang/Ghost that referenced this issue Nov 20, 2016
@kirrg001 @geekhuyang
🎨 Separate invites from user
32a56f2 
refs TryGhost#7420
- remove invite logic from user
- add invite model and adapt affected logic for inviting team members
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinansfield kevinansfield

Labels
None yet
Projects
None yet
Milestone
1.0.0-alpha.2
Development

No branches or pull requests
2 participants
@kevinansfield @kirrg001