This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
🐛 Fixed "Someone else is editing" errors showing when no-one else is editing #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…editing closes TryGhost/Ghost#8969 Collision detection errors were appearing incorrectly because the save routines in the post settings menu bypass the sequential saves in the main editor controller and so are prone to having stale data if a previous save is still in progress. - added a new `savePost` task that is part of the `saveTasks` group so that all post saves are sequential - pass the `savePost` task to the `{{gh-post-settings-menu}}` component - use `savePost` task in `gh-post-settings-menu` instead of calling `save()` directly on the model instance
2 tasks
|
Cool! Will review tomorrow morning 👍 |
kirrg001
approved these changes
Nov 2, 2017
|
Wasn't able to find a problem with this change. Feel free to self-merge for the release later 👍 |
|
Ugh, I really need to fix that test which consistently randomly fails on Travis 😞 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes TryGhost/Ghost#8969
Collision detection errors were appearing incorrectly because the save routines in the post settings menu bypass the sequential saves in the main editor controller and so are prone to having stale data if a previous save is still in progress.
savePosttask that is part of thesaveTasksgroup so that all post saves are sequentialsavePosttask to the{{gh-post-settings-menu}}componentsavePosttask ingh-post-settings-menuinstead of callingsave()directly on the model instanceNote: See TryGhost/Ghost#8969 for local reproduction steps.