Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cron Header is removed by ghost setup ssl-renew #348

Closed
yoonsikp opened this issue Jul 11, 2017 · 2 comments · Fixed by #371
Closed

Cron Header is removed by ghost setup ssl-renew #348

yoonsikp opened this issue Jul 11, 2017 · 2 comments · Fixed by #371
Assignees

Comments

@yoonsikp
Copy link

Issue Summary

Installing on Debian 9.0
Both ghost setup ssl-renew and ghost install with SSL renewal removes the header from the crontab file.

This is the header:

# Edit this file to introduce tasks to be run by cron.
#
# Each task to run has to be defined through a single line
# indicating with different fields when the task will be run
# and what command to run for the task
#
# To define the time you can provide concrete values for
# minute (m), hour (h), day of month (dom), month (mon),
# and day of week (dow) or use '*' in these fields (for 'any').#
# Notice that tasks will be started based on the cron's system
# daemon's notion of time and timezones.
#
# Output of the crontab jobs (including errors) is sent through
# email to the user the crontab file belongs to (unless redirected).
#
# For example, you can run a backup of all your user accounts
# at 5 a.m every week with:
# 0 5 * * 1 tar -zcf /var/backups/home.tgz /home/
#
# For more information see the manual pages of crontab(5) and cron(8)
#
# m h  dom mon dow   command

This header should be preserved for beginner users.

Technical details:

  • Ghost Version: Ghost v1.0.0-rc.1
  • Node Version: v6.11.1
  • Browser/OS:
  • Database: sqlite
@acburdine
Copy link
Member

FWIW - this is not caused by the CLI itself, but by the crontab library the CLI uses to edit the crontab file.

@sebgie
Copy link
Contributor

sebgie commented Jul 13, 2017

There was the idea of a lineinfile feature for ghost-cli some time back. Alternatively we could switch the crontab lib with one that keeps the comments in the file?

But definitely something after 1.0.0 :-).

acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Jul 21, 2017
closes TryGhost#363, closes TryGhost#365, closes TryGhost#348, closes TryGhost#332, closes TryGhost#183
- move nginx configuration to templates
- rely on acme.sh for cronjobs, remove ssl-renew setup and command
- cleanup & simplify nginx setup
- add subdirectory support
acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Jul 21, 2017
closes TryGhost#363, closes TryGhost#365, closes TryGhost#348, closes TryGhost#332, closes TryGhost#183
- move nginx configuration to templates
- rely on acme.sh for cronjobs, remove ssl-renew setup and command
- cleanup & simplify nginx setup
- add subdirectory support
acburdine added a commit that referenced this issue Jul 21, 2017
closes #363, closes #365, closes #348, closes #332, closes #183
- move nginx configuration to templates
- rely on acme.sh for cronjobs, remove ssl-renew setup and command
- cleanup & simplify nginx setup
- add subdirectory support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants