Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local dev server does not shut down on correctly, throws fatal error on attempted restart. #368

Closed
1 of 2 tasks
triestpa opened this issue Jul 19, 2017 · 1 comment · Fixed by #370
Closed
1 of 2 tasks
Assignees
Labels

Comments

@triestpa
Copy link

triestpa commented Jul 19, 2017

This issue is a

  • Bug Report
  • Feature Request

Summary:

ghost restart and ghost stop fail to actually stop the server on a macOS local installation. This causes a fatal error when attempting to restart Ghost after the first run, due to the port being in use by the original process. The only way that I've found to shut down the server at this point is to manually find and stop the node process.

Steps to Reproduce:

  1. Set up a local environment using ghost install local.
  2. Visit localhost:2368 to verify that ghost is running.
  3. Run ghost restart. You should see an error that the port is in use.
  4. Run ghost stop. You should see a message that no ghost instance is currently running.
  5. Run ghost start. You should see an error that the port is in use.
  6. Visit localhost:2368 to verify that ghost is still running.

Technical details:

OS: macOS 10.12.5

Debug Information:
Node Version: v6.11.1
Ghost-CLI Version: 1.0.0-rc.3
Environment: development
Command: 'ghost start'

@aileen
Copy link
Member

aileen commented Jul 20, 2017

Hey @triestpa!

Thanks for the report! I can confirm this issue.

@aileen aileen added the bug label Jul 20, 2017
kirrg001 added a commit to kirrg001/Ghost-CLI that referenced this issue Jul 20, 2017
closes TryGhost#368

- force option from fkill does not work on mac
kirrg001 added a commit to kirrg001/Ghost-CLI that referenced this issue Jul 20, 2017
closes TryGhost#368

- if you run `ghost start`, the CLI will spawn a detached process
- this detached process will spawn another process
- the `cp.pid` was wrong in any case
- forward the pid from the spawned process back to parent process
acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Jul 21, 2017
closes TryGhost#368
- force killing on mac/linux doesn't allow the child process (ghost run) to kill the ghost server process, resulting in a orphan process that the user has to kill manually
- on windows force: true works because fkill kills the process tree, which includes the ghost server
acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Jul 21, 2017
closes TryGhost#368
- force killing on mac/linux doesn't allow the child process (ghost run) to kill the ghost server process, resulting in a orphan process that the user has to kill manually
- on windows force: true works because fkill kills the process tree, which includes the ghost server
- remove windows-specific code from TryGhost#366 as it actually didn't do
anything
acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Jul 21, 2017
closes TryGhost#368
- force killing on mac/linux doesn't allow the child process (ghost run) to kill the ghost server process, resulting in a orphan process that the user has to kill manually
- on windows force: true works because fkill kills the process tree, which includes the ghost server
- remove windows-specific code from TryGhost#366 as it actually didn't do
anything
acburdine added a commit that referenced this issue Jul 21, 2017
closes #368
- force killing on mac/linux doesn't allow the child process (ghost run) to kill the ghost server process, resulting in a orphan process that the user has to kill manually
- on windows force: true works because fkill kills the process tree, which includes the ghost server
- remove windows-specific code from #366 as it actually didn't do
anything
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants