-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(doctor) detect incorrect permissions #613
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expect(error.options.environment).to.equal('testing'); | ||
expect(cwdStub.calledOnce).to.be.true; | ||
|
||
env.cleanup(); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
aileen
force-pushed
the
folder-permissions
branch
from
February 4, 2018 10:18
0a3173c
to
fbad910
Compare
aileen
force-pushed
the
folder-permissions
branch
3 times, most recently
from
February 4, 2018 13:09
07f4d7a
to
79b1fbf
Compare
aileen
force-pushed
the
folder-permissions
branch
2 times, most recently
from
February 4, 2018 14:49
e126d72
to
b1bbdc2
Compare
refs TryGhost#47 closes TryGhost#294 - Renames `folderPermissions` to `installFolderPermissions` - Adds two more tasks: `filePermissions` and `folderPermissions` which check for the correct permissions inside of the ghost installation folder - not enabled when local processmanager is used (= local install) - calls `checkPermissions` util - `filePermissions` does not check the versions and current folder - Refactors the `contentFolderPermissions` to be named `contentFolder` and disables task when content folder is not owned by ghost or ghost user is not found. - Adds `checkPermissions` util which takes a property to specify which check should run: - `owner` checks for ownership of the content folder - `folder` checks if directories within the ghost installation folder have the correct permission (775) - `files` checks if files within the ghost installation folder have the correct permissions (664) - Adds tests
aileen
force-pushed
the
folder-permissions
branch
from
February 4, 2018 16:54
b1bbdc2
to
7ffd595
Compare
acburdine
approved these changes
Feb 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #47
closes #294
folderPermissions
toinstallFolderPermissions
filePermissions
andfolderPermissions
which check for the correct permissions inside of the ghost installation foldercheckPermissions
utilfilePermissions
does not check the versions and current foldercontentFolderPermissions
to be namedcontentFolder
and disables task when content folder is not owned by ghost or ghost user is not found.checkPermissions
util which takes a property to specify which check should run:owner
checks for ownership of the content folderfolder
checks if directories within the ghost installation folder have the correct permission (775)files
checks if files within the ghost installation folder have the correct permissions (664)