Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): prerelease should statisfy engine requirements #1025

Merged
merged 1 commit into from Oct 17, 2019
Merged

fix(utils): prerelease should statisfy engine requirements #1025

merged 1 commit into from Oct 17, 2019

Conversation

allouis
Copy link
Contributor

@allouis allouis commented Oct 17, 2019

When testing installs with a prerelease version of the CLI the satisfy check against Ghosts engines field in package.json fails.

@allouis
fix(utils): prerelease statisfies engine definition
51ed96d 
When testing installs with a prerelease version of the CLI the satisfy
check against Ghosts engines field in package.json fails.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 51ed96d on support-prerelease into d0a8ad8 on master.

acburdine
acburdine approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@acburdine acburdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 good catch!

@acburdine acburdine merged commit 8bfcc38 into master Oct 17, 2019
@acburdine acburdine deleted the support-prerelease branch October 17, 2019 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acburdine acburdine acburdine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@allouis @coveralls @acburdine