feat(nginx): ensure acme.sh is kept up-to-date #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extensions/nginx/acme.js
Outdated
| if (isInstalled()) { | ||
| return task.skip('acme.sh is already installed'); | ||
| await ui.sudo('/etc/letsencrypt/acme.sh --upgrade'); |
There was a problem hiding this comment.
Suggested change
| await ui.sudo('/etc/letsencrypt/acme.sh --upgrade'); | |
| await ui.sudo('/etc/letsencrypt/acme.sh --upgrade --home "/etc/letsencrypt"'); |
I had an issue when upgrading where it was installed in /root. Not sure the exact root-cause, but being verbose should be ok, right?
There was a problem hiding this comment.
ah yeah, probably a good idea
vikaspotluri123
approved these changes
Oct 29, 2021
acburdine
force-pushed
the
fix/acme-update
branch
from
93117cd
to
c73dff7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.