Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Nginx #159

Closed
wants to merge 2 commits into from
Closed

[WIP] Nginx #159

wants to merge 2 commits into from

Conversation

acburdine
Copy link
Member

@acburdine acburdine commented Feb 19, 2017

TODOS:

  • test this on a live server with a url

The initial version of the Nginx service will not support:

  • subdirectories
  • existing config files

While the library I'm going to use nginx-conf should make integrating the above much easier, there are some edge cases that we may want to test for, which we can wait to do until after 1.0 ships.

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.7%) to 66.106% when pulling f45ffa9 on acburdine:nginx into f244459 on TryGhost:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.7%) to 66.106% when pulling 8d4a23c on acburdine:nginx into f244459 on TryGhost:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.5%) to 65.321% when pulling b752ae9 on acburdine:nginx into f244459 on TryGhost:master.

@acburdine acburdine mentioned this pull request Feb 26, 2017
7 tasks
refs TryGhost#64
- add nginx service
- add ssl provisioning via greenlock-cli
@acburdine
Copy link
Member Author

Closing in favor of a different approach.

@acburdine acburdine closed this Feb 28, 2017
@acburdine acburdine deleted the nginx branch March 2, 2017 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants