Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sleep command in CI local-e2e test workflow #1785

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

cmraible
Copy link
Contributor

@cmraible cmraible commented Sep 13, 2023

no issue

  • local e2e tests were failing on macos because of improper usage of the sleep command
  • on macos, the sleep command doesn't accept a suffix (e.g. 's', 'm', 'h'), only an integer which by default is in seconds

@cmraible cmraible marked this pull request as draft September 13, 2023 19:44
@cmraible cmraible changed the title Updated sleep command to fix local-e2e tests Fixed sleep command in CI local-e2e test workflow Sep 13, 2023
@cmraible cmraible marked this pull request as ready for review September 13, 2023 20:02
@cmraible cmraible merged commit 42ec13b into TryGhost:main Sep 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant