Allow ghost backup
to run with --no-prompt
, take authData from command line arguments
#1817
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ghost backup --no-prompt
wasn't actually taking the arguments from the command line required to properly call the exportTask (authData).This commit checks for authData {username, password} from the command line and passes through to the necessary task calls.
The test spec setup for these were a bit odd (I've never looked at this codebase before but this was blocking my work), so here are some screenshots? 😅
Note: One of the screenshotted "working" calls fails because localhost in Node 18 automagically favors iPv6. We successfully auth for the backup process with
--no-prompt
and some auth arguments.Throw SystemError when not username and password passed but in no-prompt mode:
![Screenshot 2024-01-27 at 6 33 00 PM](https://private-user-images.githubusercontent.com/17029312/300226644-351bdad4-5969-41f6-8612-edccdaca72e1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAxMTkyNDEsIm5iZiI6MTcyMDExODk0MSwicGF0aCI6Ii8xNzAyOTMxMi8zMDAyMjY2NDQtMzUxYmRhZDQtNTk2OS00MWY2LTg2MTItZWRjY2RhY2E3MmUxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA0VDE4NDkwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVkYWQxMDczYzZlYjc3ZDBlMzRlNTZiMmFkN2NjYmUzMGVkZTgxYzQyMzk1ZDU1ZGVkZDZhMTVjMjk1NTA0ZDEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.wsvFId2v4z-BxwhXR09Hy11AsYxi-FgLADaBBsy0ji8)
Without
![Screenshot 2024-01-27 at 6 32 27 PM](https://private-user-images.githubusercontent.com/17029312/300226645-0c2c9b14-0c0f-406b-ad0e-1f0f57e1c330.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAxMTkyNDEsIm5iZiI6MTcyMDExODk0MSwicGF0aCI6Ii8xNzAyOTMxMi8zMDAyMjY2NDUtMGMyYzliMTQtMGMwZi00MDZiLWFkMGUtMWYwZjU3ZTFjMzMwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA0VDE4NDkwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRmZDdhMzE1ZjYzY2E0NjdjN2VlYWUzM2ZkODkxZWUyNWJiNjU1ODc5ZTM3MTJhMzhhY2E3ZWYyNjAwNWM5ZWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.KEWM5DmVkUDwkHDXKLEumy70JWPmL6ye9tpcS9BSGaM)
--no-prompt
, use AuthData from interactive CLI:With authdata provided and
![Screenshot 2024-01-27 at 6 42 24 PM](https://private-user-images.githubusercontent.com/17029312/300226643-3a1493c6-ea85-410f-8334-8d9b27ed760a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAxMTkyNDEsIm5iZiI6MTcyMDExODk0MSwicGF0aCI6Ii8xNzAyOTMxMi8zMDAyMjY2NDMtM2ExNDkzYzYtZWE4NS00MTBmLTgzMzQtOGQ5YjI3ZWQ3NjBhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA0VDE4NDkwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJmMWY3YTE0NDQ3ODkwY2NlYzA2OTgwZDBiNGU1OTYzNTE3NjFmMjc1YzgwNmE1YjVjYjg3MWExYzhjMDViYzkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.TZh_r2ZNWmgxCvxtUo1hE8AwK7iRYp5ZdiORqvQYwrs)
--no-prompt
, successfully auth (don't worry, test password for my local dev instance):Working on my actual Ghost instance: