Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server_name directive to nginx ssl block #193

Merged
merged 1 commit into from May 5, 2017

Conversation

ErisDS
Copy link
Member

@ErisDS ErisDS commented May 3, 2017

Not sure if anything else is needed here (didn't see any related tests), but this fixes a particularly annoying bug that I'd like to get sorted in a release sometime soon 馃榿

closes #186

  • adds a single extra line to the ssl block
  • allows multiple blogs to be installed on one server

closes TryGhost#186

- adds a single extra line to the ssl block
- allows multiple blogs to be installed on one server
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 55.614% when pulling 64c5ade on ErisDS:issue-186 into d60d77b on TryGhost:master.

Copy link
Member

@acburdine acburdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

@acburdine acburdine merged commit 22be390 into TryGhost:master May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure Nginx service adds server_name config directive to both ssl and regular server blocks
3 participants