✨ use knex-migrator

[kirrg001]

TODO

• test this code
• knex-migrator package.json
• forward path to knex migrator where to find the .knex-migrator file

Check database health before starting Ghost and run knex-migrator init if database was never initialised.

[coveralls]

Coverage remained the same at 81.448% when pulling e1b8f5d on kirrg001:feature/knex-migrator into d01852e on TryGhost:master.

[kirrg001]

@acburdine the new Ghost-CLI version won't run with an older Ghost alpha version when merging this PR

[coveralls]

Coverage decreased (-2.7%) to 78.788% when pulling 5a26c85 on kirrg001:feature/knex-migrator into d01852e on TryGhost:master.

[coveralls]

Coverage remained the same at 78.788% when pulling 17b259b on kirrg001:feature/knex-migrator into 596a668 on TryGhost:master.

[coveralls]

Coverage remained the same at 78.788% when pulling 17b259b on kirrg001:feature/knex-migrator into 596a668 on TryGhost:master.

[coveralls]

Coverage remained the same at 78.788% when pulling c17dcb6 on kirrg001:feature/knex-migrator into 596a668 on TryGhost:master.

[coveralls]

Coverage remained the same at 78.788% when pulling 70195fa on kirrg001:feature/knex-migrator into 596a668 on TryGhost:master.

[coveralls]

Coverage remained the same at 78.788% when pulling 89229ba on kirrg001:feature/knex-migrator into 596a668 on TryGhost:master.

[coveralls]

Coverage remained the same at 78.788% when pulling 79fb9b5 on kirrg001:feature/knex-migrator into 596a668 on TryGhost:master.

[acburdine]

@kirrg001 I went ahead and changed the code to what I was asking (because needing to get this merged) - but here's why:

The cli has to require each command file (so it can get all of the necessary variables like command name, arguments, options, etc). Because of this, adding a bunch of require statements to the top of the file increases load times, especially when the command is not even being run (for example, if you run ghost config - you don't even need ghost start or its dependency on "knex-migrator", yet with your code knex-migrator would still be loaded).

Basically, this is probably over-ambitious optimization, but as it was a quick change and the same practice is followed everywhere else in the code, I think it's necessary.

I'm willing to revert this change in the future if there's good reason to, though 😄

[acburdine]

So I pulled this locally to test - and it's not working - neither sqlite nor mysql dependencies are installed, so ghost start doesn't work. And I'm not sure that having ghost-cli depend on both sqlite and mysql is a good idea... 😕

[kirrg001]

So I pulled this locally to test - and it's not working - neither sqlite nor mysql dependencies are installed, so ghost start doesn't work. And I'm not sure that having ghost-cli depend on both sqlite and mysql is a good idea... 😕

ghost start might not work because of a missing PR in Ghost?
https://github.com/TryGhost/Ghost/pull/7585/files

[coveralls]

Coverage remained the same at 78.788% when pulling 7feba78 on kirrg001:feature/knex-migrator into 4ecc2e3 on TryGhost:master.