Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for major blog update #771

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

kirrg001
Copy link
Contributor

@kirrg001 kirrg001 commented Jul 31, 2018

refs #759

  • executed new task if you are migrating from v1 to v2
    • do not execute the new task if you are migrating from v1 to v1
    • do not execute the new task if you are already on v2
  • this task will:
    • scan your theme with GScan 2.0
    • load the demo post from your database
    • show a nice UI and prompts
  • added unit tests

TODO

  • add tests
  • fix tests
  • full manual test
  • update UI
  • abord when fatal errors are detected
  • it could be that the demo post doesn't exist
  • source out this huge function to ...?

@kirrg001 kirrg001 changed the title [WIP] Update major support [WIP] Added support for major blog update Jul 31, 2018
this.ui.log('Theme is compatible.\n')
}

return this.ui.prompt({

This comment was marked as abuse.

This comment was marked as abuse.

return connection.raw('SELECT uuid FROM posts WHERE slug="v2-demo-post";')
})
.then((demoPost) => {
if (demoPost.length) {

This comment was marked as abuse.

@kirrg001 kirrg001 force-pushed the update-major-support branch 6 times, most recently from 30c8b24 to e728b4b Compare August 9, 2018 15:24
refs TryGhost#759

- execute new task if you are migrating from v1 to v2
- this task will:
  - scan your theme with GScan 2.0
  - load the demo post from your database
- added nice UI output
- added unit tests
@kirrg001 kirrg001 changed the title [WIP] Added support for major blog update Added support for major blog update Aug 9, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 99.597% when pulling b8afab7 on kirrg001:update-major-support into 464d13a on TryGhost:1.9.

@kirrg001 kirrg001 merged commit 0f5e050 into TryGhost:1.9 Aug 9, 2018
acburdine pushed a commit to acburdine/Ghost-CLI that referenced this pull request Aug 16, 2018
…sion (TryGhost#771)

refs TryGhost#759
- executed new task if you are migrating from v1 to v2
  - do not execute the new task if you are migrating from v1 to v1
  - do not execute the new task if you are already on v2
- this task will:
  - scan your theme with GScan 2.0
  - load the demo post from your database
  - show a nice UI and prompts
- added unit tests
acburdine pushed a commit that referenced this pull request Aug 16, 2018
refs #759
- executed new task if you are migrating from v1 to v2
  - do not execute the new task if you are migrating from v1 to v1
  - do not execute the new task if you are already on v2
- this task will:
  - scan your theme with GScan 2.0
  - load the demo post from your database
  - show a nice UI and prompts
- added unit tests
acburdine pushed a commit that referenced this pull request Aug 16, 2018
refs #759
- executed new task if you are migrating from v1 to v2
  - do not execute the new task if you are migrating from v1 to v1
  - do not execute the new task if you are already on v2
- this task will:
  - scan your theme with GScan 2.0
  - load the demo post from your database
  - show a nice UI and prompts
- added unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants